search

bentatum / better-react-spinkit

A collection of loading indicators for React
http://better-react-spinkit.benjamintatum.com/
ISC License
185 stars 25 forks source link

Improve bundle size by using lodash sub-modules #23

Closed juhamust closed 2 years ago

juhamust commented 6 years ago

For example, when using in app:

With optimisation:

144.47 KB build/static/js/main.e189deef.js 483 B build/static/css/main.08f5022c.css

Without optimisation:

156.94 KB (+12.47 KB) build/static/js/main.5906100c.js 483 B build/static/css/main.08f5022c.css

Fixes issue #22

Reaverart commented 6 years ago

@juhamust can you also update package.json to list each needed lodash dependency as separate module? I left comment here why thats needed https://github.com/bentatum/better-react-spinkit/issues/11#issuecomment-366020100 . https://www.npmjs.com/browse/keyword/lodash-modularized

I might do PR on my own, just this one is related

UPD: sorry its already here, didnt noticed at a first time

Reaverart commented 6 years ago

@bentatum sorry for the call, but as I see there is no move for a months with this PR and I want to say why this PR is important: the main benefit of it is not few saved kb, the real problem is that lodash listed as peer dependency but not all projects uses 4.x version. At the same time some of lodash methods you are import presented only in 4.x version. If you accept this PR seems it will fix this problem, because then all the needed lodash dependencies will be listed explicitly and installed if they are missing. @juhamust can you resolve merge conflict? Or can I follow up somehow? I hope owner will merge it then.

AndyOGo commented 6 years ago

@bentatum Why is this not merged yet?