search

bentglasstube / Net-MPD

5 stars 1 forks source link

Returning full metadata (information request) #3

Closed john- closed 10 years ago

john- commented 10 years ago

I don't see a way of returning song metadata such as album, artist, etc. If this is the case should new methods be added to do this or should existing ones be used/modified? I was thinking list_all_info would do it but it appears to return same stuff as list_all.

bentglasstube commented 10 years ago

Interesting, list_all_info should definitely be providing the metadata since that's what the documentation states it does. I will look into why it is not doing so.

bentglasstube commented 10 years ago

For me, the functions work as documented. Perhaps your MPD database does not have the metadata available? Can you try mpc listall -f '%file% : %artist% - %title%' to see what metadata mpd has.

john- commented 10 years ago

mpc listall -f works as expected. I don't see any code in Net::MPD for list_all_info that would do more than what list_all does. However, I could have misread something.

I see in MPD protocol doc this new function: readcomments [URI]. I did a quick hack of Net::MPD to add this in and it returns all the tags for a file.

I will take a look at adding this to Net::MPD even if list_all_info provides the meta data.

john- commented 10 years ago

A couple things...

The mpc that is available for my distro (0.25) does not support readcomments. My hack to Net::MPD does work in all cases. There may be some corner conditions to deal with.

john- commented 10 years ago

I see above now where you indicate list_all_info works as expected for you. Clearly I missed something when I reviewed the code and I will investigate on my end further.

bentglasstube commented 10 years ago

I'm not sure why list_all_info is not working for you. The reason you don't see any specific code for that command is the parser for the results is the same regardless of if the metadata is present. If possible, could you provide the raw data sent to and from mpd by setting NET_MPD_DEBUG environment variable and paste the output here? I just added that functionality so you will need to make sure you have the latest Net::MPD from GitHub (not CPAN).

On Wed, Mar 05, 2014 at 04:47:21PM -0800, john- wrote:

A couple things...

The mpc that is available for my distro (0.25) does not support readcomments. My hack to Net::MPD does work in all cases. There may be some corner conditions to deal with.

Reply to this email directly or view it on GitHub: https://github.com/bentglasstube/Net-MPD/issues/3#issuecomment-36813299

Alan Berndt

We are all in the gutter, but some of us are looking at the stars.

john- commented 10 years ago

I was doing something wrong before because list_all_info does work as expected. Thanks for adding the debug capability hopefully it will help with a future issue.

bentglasstube commented 10 years ago

I'm glad it is sorted out. Thank you for your contributions.

On Thu, Mar 06, 2014 at 03:16:15PM -0800, john- wrote:

Closed #3.

Reply to this email directly or view it on GitHub: https://github.com/bentglasstube/Net-MPD/issues/3

Alan Berndt

When you gaze long into an abyss the abyss also gazes into you.