search

benthayer / git-gud

Wanna git gud? Then get git-gud, and git gud at git!
MIT License
401 stars 42 forks source link

Add testing for methods defined in GitGud object #314

Closed sahansk2 closed 3 years ago

sahansk2 commented 3 years ago

Fixes #197

@benthayer Could you verify for which methods you would like tests?

benthayer commented 3 years ago

It might (probably will) make sense to split this up into multiple PRs

sahansk2 commented 3 years ago

If you'd like multiple PRs, would you also like multiple issues for this? E.g. "Test user methods using webbrowser", "Test user methods related to loading", "Test assert initialized methods", etc?

benthayer commented 3 years ago

Yes, I think that makes sense. Obviously, there would be many issues, and writing the issues might take as long as it takes to simply write the test, so do what you feel is right. There should either be a pull request or an issue for each test

sahansk2 commented 3 years ago

What we could do is make a new "meta-issue", similar to what #238 is. Each checkbox could be a method in the GitGud object.

Going off of this, we could maintain another branch user_tests on this repository, and people open up testing PRs to merge to user_tests. Once all the tests are in and everything looks set, we merge user_tests into master. This is similar to what the intro branch (or the add branch, I forget) was like a while back.

I'm not sure what's best, so it's your call. As an aside, should this PR be closed?

benthayer commented 3 years ago

I think we can open a meta-issue (along with other issues)

I don't think we need to make a separate branch for the tests, I think we can merge them right into master when they are done.

This PR can stay open until there exists other issues/PRs that make use of the useful comments that are here

benthayer commented 3 years ago

Stale/closing