search

benthosdev / benthos-captain

A Kubernetes Operator to orchestrate Benthos pipelines
MIT License
38 stars 9 forks source link

add basic helm chart #13

Closed charlie-haley closed 5 months ago

charlie-haley commented 5 months ago

Fixes https://github.com/benthosdev/benthos-captain/issues/5

This currently doesn't deploy, but I'm planning to push it to a different repository (benthosdev/charts) along with the actual Benthos Helm Chart so all of the charts are in one place.

mfamador commented 5 months ago

It's considered a best practice not having the crds on templates and keep them on crds folder.

Ex. https://github.com/istio/istio/tree/master/manifests/charts/istio-operator

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you

charlie-haley commented 5 months ago

It's considered a best practice not having the crds on templates and keep them on crds folder.

Ex. https://github.com/istio/istio/tree/master/manifests/charts/istio-operator

https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you

Ah good catch, that wasn't supposed to be nested in the templates folder