search

benthosdev / benthos-lab

A web app for writing, executing and sharing Benthos pipeline configurations
https://lab.benthos.dev
MIT License
47 stars 8 forks source link

migrating to go1.14 #19

Closed DpoBoceka closed 4 years ago

DpoBoceka commented 4 years ago

Closes https://github.com/benthosdev/benthos-lab/issues/18 Now it's able to run on firefox. Safari, however, still has an issue Unhandled Promise Rejection: RangeError: Maximum call stack size exceeded

DpoBoceka commented 4 years ago

Is it breaking anything? What did you use vendor for in the first place? https://github.com/benthosdev/benthos-lab/pull/19/files#diff-3254677a7917c6c01f55212f86c57fbfL9

Jeffail commented 4 years ago

Ace, thanks @DpoBoceka, the vendoring prevents you needing to pull the deps twice when you already have them locally. It was breaking because the first step of the drone CI script calls go mod vendor using go version 1.12, but I'll just remove that as it's not needed.