Add `persistent` field to the `amqp_1` output

benthosdev / benthos

Fancy stream processing made operationally mundane

https://www.benthos.dev

MIT License

7.68k stars 752 forks source link

Add `persistent` field to the `amqp_1` output #2520

Closed mihaitodor closed 4 weeks ago

mihaitodor commented 1 month ago

The amqp_0_9 has this field already: https://www.benthos.dev/docs/components/outputs/amqp_0_9/#persistent

Implementation inspired from here: https://github.com/Azure/go-amqp/issues/11

This omission was reported on Slack: https://gophers.slack.com/archives/CLWCBK7FY/p1713189832118529

TODO:

[ ] Wait for confirmation that it works as expected

mihaitodor commented 4 weeks ago

Thanks for the review @timo102! These changes were meant more as a test based on a support conversation on the Golang Gophers Slack. I also saw that someone else suggested something similar in #2530 and I'm happy to close this one and move the discussion there, since I don't really understand this protocol well enough.