OrderItems[] was empty

[vcardillo]

See bentocorp/ios#219

140 will help isolate for sure whether this is iOS or Android, but now I believe that this bug is somehow in both platforms.

This bug started when we just had iOS, and now I've recently asked some users what platform they're on, and some are saying Android too.

[vcardillo]

I see that you added some additional code. Did you determine what is causing this?

[xkokushox]

Yep the code i added is to prevent to send an empty order, right now i don't see any problems in the code at sending an order i will keep testing, with other variables (like send the app to back)

[vcardillo]

But why does it happen in the first place? And what will the customer experience if their array somehow becomes empty?

Vincent | CTO | bentonow.com (sent from mobile) On Sep 17, 2015 10:12 AM, "Kokusho Torres" notifications@github.com wrote:

Yep the code i added is to prevent to send an empty order, right now i don't see any problems in the code at sending an order i will keep testing, with other variables (like send the app to back)

— Reply to this email directly or view it on GitHub https://github.com/bentocorp/android/issues/141#issuecomment-141155110.

[vcardillo]

Any thoughts?

On Thu, Sep 17, 2015 at 11:15 AM, Vincent Cardillo vincent@bentonow.com wrote:

But why does it happen in the first place? And what will the customer experience if their array somehow becomes empty?

Vincent | CTO | bentonow.com (sent from mobile) On Sep 17, 2015 10:12 AM, "Kokusho Torres" notifications@github.com wrote:

Yep the code i added is to prevent to send an empty order, right now i don't see any problems in the code at sending an order i will keep testing, with other variables (like send the app to back)

— Reply to this email directly or view it on GitHub https://github.com/bentocorp/android/issues/141#issuecomment-141155110.

[xkokushox]

I was looking in the code, the most probably reason is that the app goes back for a lot of time, and when it returns the OrderItems[] clears, i cant reproduce it so the only option i see now is to prevent sent orders if is empty

[vcardillo]

I am just worried what the user will experience?

[xkokushox]

Me too, what i am doing is building a database to save the orders, with that i will be sure that the items will be always send

[vcardillo]

When this error happens, can we track it as an event in Mixpanel, or send it to Crashalytics, or both?

On Mon, Sep 21, 2015 at 2:41 PM, Kokusho Torres notifications@github.com wrote:

Me too, what i am doing is building a database to save the orders, with that i will be sure that the items will be always send

— Reply to this email directly or view it on GitHub https://github.com/bentocorp/android/issues/141#issuecomment-142117626.

[xkokushox]

Both, i can track custom events i will do it now

[vcardillo]

Basically, my concern is that the user will enter a race condition into the app, and won't be able to order. Here is what I am worried about:

1) I build my bento. 2) This error happens, and the array is empty. App prevents me from ordering. 3) the UI still shows my bento is full. 4) UI shows bento is full, but app prevents me from ordering because the array is empty. Now what? This is the race condition that I am worried about.

[xkokushox]

that should not happen in a normal way but for is some strange reason that happens, first we will ask the user to build the bento again ant then shows the build bento screen to start the process again.

I had added the crashlytics and mixpanel error to know when that happens. What do you think?

[vcardillo]

Yea, I just want to really track this carefully, because this scenario (building again) would be annoying for users.

There's no way to re-populate the array automatically?

[vcardillo]

Have we had any reports in Crashalytics of this?