search

bentodaniel / vs-tab-groups

5 stars 3 forks source link

New Feature: Edit tab group name #10

Closed carlosedilsonjr closed 3 months ago

carlosedilsonjr commented 4 months ago

Hey Daniel, I have been using your vscode extension and it helps me a lot. Recently, I needed to rename some TabGroups and I saw that is not possible. So, I did this PR with small modifications that add a new function to edit the Tab Group Name. Is it possible to merge it in your code to be available to use in my day by day? Feel free to check the code and give suggestions or modifications if needed.

PS.: Exists a way to add TabGroup inside another TabGroup? I tried it, but was unsuccessful. So, if this feature does not exist yet I think I will develop it too, but I have to search and learn a little more about this VSCode API.

bentodaniel commented 3 months ago

Looks good, i'm sorry i took this long to see review and aprove it

Also, i believe it could be possible to implementi it so we could create a TabGroup inside another, however, the whole extension would need to be addapted for it, as it was built assuming that there was only 1 level of tab groups parents