search

bentolor / idea-cli-inspector

A little command-line tool to integrate the awesome IntelliJ IDEA code inspections in your continuous integration (CI) process using Jenkins, Bamboo, et. al.
Apache License 2.0
139 stars 13 forks source link

command line arguments should override .ideainspect file #15

Closed sylvainlaurent closed 6 years ago

sylvainlaurent commented 6 years ago

It seems that if a setting is defined in the .ideainspect file, then it is not possible to pass a different setting through the command line arguments. This is quite counter-intuitive and not convenient when trying to setup a CI build

bentolor commented 6 years ago

@sylvainlaurent I could not agree more and this is also the design. Double-checked the code to assert that the design actually matches your expectations. But instead of replacing previous defined values it only readds them:

def configOpts = parseConfigFile()
configOpts.addAll(args)

It seems that CliBuilder does only take & respect the first instance …

Will have a look on it.

bentolor commented 6 years ago

1.5.4 should fix that.

The --verbose option will now also dump the effective input options.

sylvainlaurent commented 6 years ago

thanks!

sylvainlaurent commented 6 years ago

hello @bentolor ! there's a small glitch with 1.5.4 : it stil prints 1.5.3 when running...

bentolor commented 6 years ago

Thanks, @sylvainlaurent for the hint. I fixed that now, too.