search

bentolor / idea-cli-inspector

A little command-line tool to integrate the awesome IntelliJ IDEA code inspections in your continuous integration (CI) process using Jenkins, Bamboo, et. al.
Apache License 2.0
139 stars 13 forks source link

Scopes added. #6

Closed ihowell closed 8 years ago

ihowell commented 8 years ago

Hey! Let me know if I missed anything!

bentolor commented 8 years ago

Thank you very much @ianshowell for your contribution! And sorry for the notification spam (I assume GH is sending out an email on every new line comment)

I have a couple of comments. Would you like to have a look on those and discuss them?

Again. thank you very much for your contribution!

ihowell commented 8 years ago

You're fine with the notification spam. I turned off GH emails a while ago.

ihowell commented 8 years ago

All ready for next review.

bentolor commented 8 years ago

Thank you @ianshowell

On second reviewing I mostly had one question regarding the property and another minor one regarding the comment along the update idea properties. Maybe you can say word regarding my question there.

If you want I can complete these final finishing polish tasks for you while testing & merging your PR.

ihowell commented 8 years ago

I guess I don't quite understand which questions I didn't answer thoroughly enough. If you want to do the polishing tasks, that is fine, or you can inform me what I should continue to work on, @bentolor. Sorry if I'm being difficult, I'm still pretty new to github.

bentolor commented 8 years ago

@ianshowell Thanks for coming back to your merge request. I'll adjust my remaining little points and let you now. Probably it will become pretty obvious from my changes then.

Thanks again for working out a solution for the scoping. Will try to integrate this the next days.

ihowell commented 8 years ago

Sure thing. Sorry it took me so long.

ihowell commented 8 years ago

Fixes #5

bentolor commented 8 years ago

Sorry @ianshowell for my inactivity. Currently very busy due to deadlines. But your MR is on the list!

bentolor commented 8 years ago

@ianshowell I reworked your contribution a little. Please test & give feedback if it still works for you.

Thanks for contributing & sorry for the delay.