search

bentoml / BentoML

The easiest way to serve AI apps and models - Build Model Inference APIs, Job queues, LLM apps, Multi-model pipelines, and more!
https://bentoml.com
Apache License 2.0
7.13k stars 791 forks source link

bug: bentoml containerize should support multiple tags #2789

Closed dbuades closed 2 years ago

dbuades commented 2 years ago

Describe the bug

The method buildx.build support a list of tags here but containerize only send a single tag here.

This causes that when passing multiple --docker-image-tag arguments to bentoml containerize, only the last one is kept.

To reproduce

Pass multiple --docker-image-tag to bentoml containerize and only the last one will be kept.

Expected behavior

In my opinion, if multiple --docker-image-tag are passed to bentoml containerize, all of them should be passed to buildx.

Environment

bentoml: 1.0.0 python: 3.9.10 platform: macOS-12.5-arm64-arm-64bit

parano commented 2 years ago

thank you for reporting the issue @dbuades!

cc @aarnphm for bentoml containerize, the -t should support multi-options, see https://click.palletsprojects.com/en/7.x/options/#multiple-options

aarnphm commented 2 years ago

The progress will now be tracked and bugs will be fixed at #2797. Thanks for reporting this.