bentoml / BentoML

The easiest way to serve AI apps and models - Build Model Inference APIs, Job queues, LLM apps, Multi-model pipelines, and more!
https://bentoml.com
Apache License 2.0
7.13k stars 791 forks source link

bug: Bento keyword "bento_server" is forbidden in bentofile.yaml config. #3134

Closed muneebable closed 2 years ago

muneebable commented 2 years ago

Describe the bug

Version = 1.0.7 In the old version and in documentation, people used that keyword in bentoml.ymal file. But now It is not recoginizable anymore.

We tried to add:

bento_server:
  cors:  
    enabled: True
    access_control_allow_origin: "*"
    access_control_allow_methods: ["GET", "OPTIONS", "POST", "HEAD", "PUT"]
    access_control_allow_credentials: True
    access_control_allow_headers: Null
    access_control_max_age: Null
    access_control_expose_headers: ["Content-Length"]

But that doesn't work. and we got the error as displayed in the image.

image

To reproduce

No response

Expected behavior

No response

Environment

bentoml: 1.0.7 python: 3.9 platform: Ubuntu 20.04.5 LTS

aarnphm commented 2 years ago

This is not a bug, as bento_server is not an allowed key under bentofile.yaml.

There is a difference between bentofile.yaml and bentoml_configuration.yaml. You are addressing the configuration for BentoML.

bentofile.yaml is used to configure how a bento would look like.

Make sure to take a look at our quickstart guide for more information