bentoml / BentoML

The easiest way to serve AI apps and models - Build Model Inference APIs, Job queues, LLM apps, Multi-model pipelines, and more!
https://bentoml.com
Apache License 2.0
7.13k stars 791 forks source link

bug: cli not respecting flags #3184

Closed alizia closed 2 years ago

alizia commented 2 years ago

Describe the bug

The CLI tool does not respect the flags passed to it. I've noticed the following odd behaviors with bentoml serve:

--api-workers : Ignores the flag and starts workers equal to the number of cores

--quiet: Actually has the opposite effect and starts loging verbosely. It starts printing DEBUG logs as well instead of stopping printing INFO and WARN logs.

To reproduce

run bentoml serve service.py:svc --quiet --api-workers 4

Expected behavior

No response

Environment

bentoml: 1.0.0 python: 3.8.10 platform: Linux-5.15.0-1022-aws-x86_64-with-glibc2.29 uid:gid: 1000:1000

aarnphm commented 2 years ago

can you upgrade to the latest bentoml version? I believe we did fix this in the newer version.

alizia commented 2 years ago

sounds good @aarnphm. let me try out the new version.

alizia commented 2 years ago

@aarnphm you're right. works fine in the new version. I'll close the ticket. thanks.