bentoml / bentoctl

Fast model deployment on any cloud 🚀
https://bentoml.com
Other
175 stars 30 forks source link

fix: create_repository should returns repository_url instead of registry info #129

Closed jjmachan closed 2 years ago

jjmachan commented 2 years ago

Description

Currently the create_repository return the url for registry but we want to use the repository url .

Motivation and Context

How Has This Been Tested?

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #129 (812076b) into main (91191ba) will not change coverage. The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files          16       16           
  Lines         893      893           
=======================================
  Hits          645      645           
  Misses        248      248           
Flag Coverage Δ
unit-tests 72.22% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/deployment_config.py 66.66% <25.00%> (ø)
bentoctl/cli/__init__.py 86.90% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

jjmachan commented 2 years ago

Need to merge https://github.com/bentoml/aws-sagemaker-deploy/pull/35 and https://github.com/bentoml/aws-lambda-deploy/pull/37