search

bentoml / bentoctl

Fast model deployment on any cloud 🚀
https://bentoml.com
Other
175 stars 30 forks source link

fix: pass the --load flag with buildx build to make result img available #187

Closed jjmachan closed 1 year ago

jjmachan commented 1 year ago

Description

loads the final image build into system-wide docker. This fixes the docker image missing error when the docker buildx builder is a container-based one. @ssheng had experienced this issue on his system closes:

codecov[bot] commented 1 year ago

Codecov Report

Merging #187 (dcf5ef2) into main (a3471f1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   59.05%   59.05%           
=======================================
  Files          24       24           
  Lines        1138     1138           
=======================================
  Hits          672      672           
  Misses        466      466
Flag Coverage Δ
unit-tests 59.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/docker_utils.py 24.65% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ssheng commented 1 year ago

Looks like there are lint and format error. Please address and merge. @jjmachan