bentoml / bentoctl

Fast model deployment on any cloud 🚀
https://bentoml.com
Other
175 stars 30 forks source link

feat: added more options for bentoctl build to match options available via buildx #190

Closed jjmachan closed 1 year ago

jjmachan commented 2 years ago

Description

bentoctl build can now directly pass arguments supported by docker buildx. This gives more flexibility to the user in the build step.

image

closes:

codecov[bot] commented 2 years ago

Codecov Report

Merging #190 (b23000f) into main (0a85290) will increase coverage by 0.13%. The diff coverage is 68.25%.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   59.05%   59.18%   +0.13%     
==========================================
  Files          24       22       -2     
  Lines        1138     1181      +43     
==========================================
+ Hits          672      699      +27     
- Misses        466      482      +16     
Flag Coverage Δ
unit-tests 59.18% <68.25%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/cli/__init__.py 76.92% <64.28%> (-8.14%) :arrow_down:
bentoctl/cli/utils.py 62.31% <100.00%> (+0.55%) :arrow_up:
bentoctl/deployment_config.py 68.50% <100.00%> (ø)
bentoctl/docker_utils.py 26.66% <100.00%> (+2.00%) :arrow_up:
bentoctl/utils/usage_stats.py 80.76% <100.00%> (+2.50%) :arrow_up:
bentoctl/utils/__init__.py
bentoctl/__init__.py

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jjmachan commented 2 years ago

I'm ok with this, as long as this is in sync with bentoml containerize

I will keep an eye out for that. Do you have any ideas on how we might be able to avoid this altogether maybe?