bentoml / bentoctl

Fast model deployment on any cloud 🚀
https://bentoml.com
Other
175 stars 30 forks source link

feat(config): add `env` block to deployment config #196

Closed judahrand closed 1 year ago

judahrand commented 1 year ago

Description

See here for context: https://github.com/bentoml/google-cloud-run-deploy/pull/21#discussion_r984038740

UI:

Select y: image Enter BENTOML_CONFIG_OPTIONS: image Enter api_server.workers=1: image Select n: image image

closes:

judahrand commented 1 year ago

@ssheng @jjmachan How does this look to you both as an interface for including env in the deployment_config.yaml?

judahrand commented 1 year ago

I'll fix the tests when I get the chance. Didn't want to put the effort in until I knew the UI approach was reasonable/acceptable.

ssheng commented 1 year ago

@judahrand, there are maybe a few places in the unit tests that needed to be updated. Could you please help fix them when you get a chance?

codecov[bot] commented 1 year ago

Codecov Report

Merging #196 (f7571d0) into main (68574bc) will increase coverage by 0.68%. The diff coverage is 97.22%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   59.05%   59.73%   +0.68%     
==========================================
  Files          24       22       -2     
  Lines        1138     1150      +12     
==========================================
+ Hits          672      687      +15     
+ Misses        466      463       -3     
Flag Coverage Δ
unit-tests 59.73% <97.22%> (+0.68%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bentoctl/deployment_config.py 71.52% <94.73%> (+3.02%) :arrow_up:
bentoctl/cli/interactive.py 92.15% <100.00%> (+0.78%) :arrow_up:
bentoctl/__init__.py
bentoctl/utils/__init__.py

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more