aarnphm commented 1 year ago

This PR tries to relax the restriction for PyYAML and docker.

I'm not entirely sure the reason for locking this modules before. cc @jjmachan ?

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

jjmachan commented 1 year ago

The only reason was so that the dependencies don't jump major releases, incase something breaks with a major release of the dependency

aarnphm commented 1 year ago

Hmm, I feel that dependencies should only have a lower bound, as upper bound is icky.

https://iscinumpy.dev/post/bound-version-constraints/#pinning-the-python-version-is-special talks about this relatively well.

bentoctl itself is an application, rather than a library.

codecov[bot] commented 1 year ago

Codecov Report

Merging #199 (731142f) into main (731142f) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 731142f differs from pull request most recent head 74251d7. Consider uploading reports for the commit 74251d7 to get more accurate results

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files          22       22           
  Lines        1220     1220           
=======================================
  Hits          729      729           
  Misses        491      491

Flag	Coverage Δ
unit-tests	`59.75% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jjmachan commented 1 year ago

that is true. I've updated the poetry.lock file so that it uses the latest dependencies for our CI.

Could you take a look at #197. Once that is merged the CI should be fixed

bentoml / bentoctl

chore: relax pypi restriction #199

Codecov Report