codecov[bot]
commented
10 months ago Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.
Comparison is base (
3c1e08c) 58.92% compared to head (5acffe0) 58.86%.
| Files | Patch % | Lines |
|---|---|---|
| bentoctl/deployment_config.py | 16.66% | 10 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== - Coverage 58.92% 58.86% -0.07% ========================================== Files 24 24 Lines 1266 1264 -2 ========================================== - Hits 746 744 -2 Misses 520 520 ``` | [Flag](https://app.codecov.io/gh/bentoml/bentoctl/pull/214/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bentoml) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/bentoml/bentoctl/pull/214/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bentoml) | `58.86% <16.66%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bentoml#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
michaelromagne
Description
bentoctl version 0.4.0 is bugged as raised in two issues recently :
This is due to the context manager not being passed to the operator somehow, so the temporary file system is not found : https://github.com/bentoml/bentoctl/blob/3c1e08c75b6bad92a82941834a6a803a9251689d/bentoctl/deployment_config.py#L247-L257
Going back to version 0.3.4 does not work as the models are not copied at all in the bento before deployment on EC2 using kubectl.
As a quick fix I propose to replace the context manager by a permanent copy of models in the bento that will be deployed.