search

bentoml / yatai-deployment

🚀 Launching Bento in a Kubernetes cluster
17 stars 14 forks source link

Ability to configure tis secret for network layer #87

Open zifeo opened 1 year ago

zifeo commented 1 year ago

Currently, it does not seem to be able to set a secret for the ingress, and thus cert-manager cannot be used out of the box.

layers:
  network:
    ingressClass: nginx
    ingressAnnotations:
      cert-manager.io/cluster-issuer: letsencrypt
    ingressPath: /
    ingressPathType: ImplementationSpecific
    tls: true # ← suggested
yetone commented 1 year ago

We already have a tls field in ingress: https://github.com/bentoml/yatai-deployment/blob/v1.0.x/helm/yatai-deployment/crds/bentodeployment.yaml#L2133

zifeo commented 1 year ago

@yetone thanks, I indeed saw the feature in the CRD but I would expect to be able to set an autogenerated name for all deployments in the chart. This ways, both CRD and GUI deployments will use that as a default.

yetone commented 1 year ago

@zifeo Good point, thanks for the suggestion, I will add this feature as soon as possible