Open jessehanley opened 2 years ago
Hi Jesse!
That function is related to the options below:
So you can control the frequency and enable/disable that function.
Examples:
Send "user not completed content" events after (days)
will disable that function or you can increase the time to send fewer events. Repeat user "not-events" each (days)
allow you to control the frequency that those events are sent again. Increasing that value will send fewer events too, or you can just disable it by setting 0.Now, the default value is 0. So it's already disabled by default. Please let me know if you need anything else.
Hey @estevao90,
Thanks for replying!
I don't know if that is true though. The user this is an issue with has the following setup:
Based on this and your explanation, no events should be sending.
But the WP install is sending us so many events still:
Why is this?
I'm a bit of a PHP n00b but reading the file, it seems the cron is registered but no checks are made for bento_learndash_scheduled_events_hook()
?
Hi, Jesse!
Oh, I got the issue. We're not updating the cron register. So, the cron is still registered and active. I'll send a fix by the following week.
To fix it now, you can just delete the related cron tasks. To do it, you can install the WP Crontrol plugin and go to Tools -> Control events. Then, you'll be able to delete the bento tasks (image below). Sorry for that!
Sweet! I'll ping impacted clients, tag me when you do the release @estevao90 ✌️
Thanks brother!
@jessehanley I pushed the fix for that issue.
Please let me know if it works well in their case.
@estevao90 sweet, merged in and will send to peeps.
One of the users mentioned that deleting the cron didn't work as it would keep appearing again and again.
Does this fix tackle that too?
Ah, Yep! I fixed it.
Hey @estevao90 — the user has tried to remove the cron multiple times but it keeps appearing. Any ideas? I have to now request he remove the plug-in because of the event volume he's sending.
Hi @jessehanley
Is the user using the latest committed version? Any chance I have access to their environment? So I can investigate the issue as I can't replicate that problem here.
Ah, that problem happens with all customers or it's a specific user issue?
It's weird because even the previous version doesn't have this problem here.
Hey @codemonkey-jack and @estevao90,
Would it be possible to add a toggle to turn the
bento_learndash_scheduled_events_hook()
on and off? With default being off? We have sites that are DDoSing us hourly because of it — it's just way too much event data to send our way.Code found here: https://github.com/bentonow/bento-wordpress-sdk/blob/e632d29a3ed16b21d1d21b9c704c2be5aa09ec40/inc/events-controllers/class-learndash-bento-events.php#L327-L334
Screenshot of events coming in:
Appreciate it!