search

bentonstark / starksoft-aspen

.net / mono security and cryptography library that provides client support for ftps, gnupg, smartcard, and socks / http proxies
108 stars 49 forks source link

Output Signature Types #18

Closed mitjag closed 8 years ago

mitjag commented 8 years ago

Added _localUser switch for selecting signing user Added OutputSignatureTypes for ClearText, Detached and Signature

csowa commented 8 years ago

If you look back at https://github.com/bentonstark/starksoft-aspen/pull/9, you'll see a pull request for local user support already ;-)

Also, if you don't mind a bit of feedback, you should watch your whitespace to avoid committing extraneous changes.

mitjag commented 8 years ago

True #9 is the same, I guess we both needed the functionality before it is/was merged to master :) The second feature is new OutputSignatureTypes property (ClearText, ...).

Sorry about the white space changes (Visual Studio did the auto formatting). Should I revert the white spaces and create new pull request?

csowa commented 8 years ago

I think it's up to @bentonstark about the whitespace.

Would it be better to add your new feature to my fork and do a pull request here for the result? I'm not sure that's how that would work. In any case, there's now two conflicting pull requests. Another thing for @bentonstark to resolve, I guess, but it would be nice if we could reduce the effort needed somehow.

bentonstark commented 8 years ago

Looks like I need to take a look at these pull requests and integrate the ones that make sense. I can fix the white space issues.

csowa commented 8 years ago

FYI, what brought me back here today was that I got a ping via email from someone who wanted to use some subset of the changes that I had made in #9 since it wasn't in NuGet. I replied that he could use that fork's source, but I'm sure he'd prefer to use an updated package if possible. I'll let him know there's an active discussion here now.

bentonstark commented 8 years ago

You can let him know I am working on it. Right now I am building a new environment on my Linux machine so I can manage this library with mono. I have been out of the .NET world for a while...

bentonstark commented 8 years ago

I added this feature via a direct code change. Should get a code push out today so I will close this pull request.

csowa commented 8 years ago

Thank you!