search

bentorfs / angular-bootstrap-multiselect

Native angularJS custom form element
http://bentorfs.github.io/angular-bootstrap-multiselect/
MIT License
79 stars 111 forks source link

Translate multiselect labels #23

Closed stand579 closed 7 years ago

stand579 commented 7 years ago

Hello,

First of all thank you for the great directive. We've been using it successfully in our application and we're very satisfied.

However, now our application evolved to the point we need to translate it into many languages. I was looking into the source code (release version 1.1.4) and saw that labels like "Select", "Select All", "Unselect All" and "{{ N }} selected" are hard-coded in the code, so we can't translate them.

Could you please change the directive to allow us provide translations in different languages?

Thanks in advance.

bentorfs commented 7 years ago

Hi Stanislava,

I am not currently actively maintaining this, but you are welcome to fork the project and/or make a pull request :-)

Cheers,

Ben

On Mon, Nov 28, 2016 at 5:42 PM Stanislava Nedyalkova < notifications@github.com> wrote:

Hello,

First of all thank you for the great directive. We've been using it successfully in our application and we're very satisfied.

However, now our application evolved to the point we need to translate it into many languages. I was looking into the source code (release version 1.1.4) and saw that labels like "Select", "Select All", "Unselect All" and "{{ N }} selected" are hard-coded in the code, so we can't translate them.

Could you please change the directive to allow us provide translations in different languages?

Thanks in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bentorfs/angular-bootstrap-multiselect/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AGFQ_Gi3bmB3AZVQoaXLaBSr7JOO5U0Zks5rCwRYgaJpZM4K9_gk .

stand579 commented 7 years ago

Thanks Ben, are you planning to release a new version soon?

bentorfs commented 7 years ago

I can do a grunt bump (or you can do it yourself, I made you collaborator), but I'm not sure what the process is like to upload to NPM. It was done by AmitMY in https://github.com/bentorfs/angular-bootstrap-multiselect/issues/9

On Fri, Dec 9, 2016 at 5:02 PM Stanislava Nedyalkova < notifications@github.com> wrote:

Thanks Ben, are you planning to release a new version soon?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/bentorfs/angular-bootstrap-multiselect/issues/23#issuecomment-266049909, or mute the thread https://github.com/notifications/unsubscribe-auth/AGFQ_EdkkQ-lyOeXZht-f_dwb2sPpyGvks5rGXuWgaJpZM4K9_gk .

stand579 commented 7 years ago

The fix for this issue was added in PR #25 so I'm closing this issue.