Compilation fails with GCC-11

[xcom169]

Hello All,

Compilation fails with GCC-11 on Arch Linux:
RedHammer/redhammer.c:193:15: error: expected ‘;’ before ‘}’ token 193 | return num | ^ | ; 194 | #endif 195 | } | ~

RedHammer/redhammer.c:202:15: error: expected ‘;’ before ‘}’ token 202 | return num | ^ | ; 203 | #endif 204 | } | ~


[bentorkington]

thanks @xcom169, I've added the missing semicolons, and it should build now.

This escaped detection so far because I haven't tested a build on a big-endian machine, so that code that failed is #ifdef'd out. Can you confirm you're actually building on a big-endian CPU? Otherwise, if you're building on x86 for example, the __LITTLE_ENDIAN__ flag should be set, and that code should not have actually been encountered.

[cont'd] if you do have a big endian machine, it'd be good to know if that build runs okay and has no bugs that the little endian build doesn't also. The last time I tested this on big endian was about 10 years ago. I've got an old G4 iMac in storage with a dead hard drive I've been meaning to resurrect to test the BE build

[xcom169]

Hello.

I used a x86 CPU and the CMake script to build it.

On Fri, 20 Jan 2023 at 19:54, bentorkington @.***> wrote:

thanks @xcom169 https://github.com/xcom169, I've added the missing semicolons, and it should build now.

This escaped detection so far because I haven't tested a build on a big-endian machine, so that code that failed is #ifdef'd out. Can you confirm you're actually building on a big-endian CPU? Otherwise, if you're building on x86 for example, the __LITTLE_ENDIAN__ flag should be set, and that code should not have actually been encountered.

— Reply to this email directly, view it on GitHub https://github.com/bentorkington/sf2ww/issues/6#issuecomment-1398804315, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2G2WDVF4TXN7QR4L4WJDWTLNPHANCNFSM6AAAAAAUBOQY6I . You are receiving this because you were mentioned.Message ID: @.***>

[bentorkington]

Okay, I guess something's wrong with the script if it's trying to compile for BE, will have a look, thanks

[bentorkington]

Can't repro this with gcc-10 on Debian. Check your compiler is defining either __i386__ or __amd64__ I guess

[xcom169]

Hello!

I tried again with GCC 12. Now it's better but there is another issue with cmocka.h :

sf2ww/FBTests/main.c:13:10: fatal error: cmocka.h: No such file or directory 13 | #include | ^~~~~~ compilation terminated. make[2]: [FBTests/CMakeFiles/test-redhammer.dir/build.make:76: FBTests/CMakeFiles/test-redhammer.dir/main.c.o] Error 1 make[1]: [CMakeFiles/Makefile2:126: FBTests/CMakeFiles/test-redhammer.dir/all] Error 2 make: *** [Makefile:101: all] Error 2

On Sat, 21 Jan 2023 at 04:44, bentorkington @.***> wrote:

Can't repro this with gcc-10 on Debian. Check your compiler is defining either i386 or amd64 I guess

— Reply to this email directly, view it on GitHub https://github.com/bentorkington/sf2ww/issues/6#issuecomment-1399167867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2G2TB6KJRQILZHUPBTCDWTNLQZANCNFSM6AAAAAAUBOQY6I . You are receiving this because you were mentioned.Message ID: @.***>

[bentorkington]

I need to update the docs to include the cmocka dependency (for unit tests) and also allow the project to build without tests if this dep is not found. In the meantime, cmocha is available for Arch Linux, so you should be able to install that to get the build working

[bentorkington]

@xcom169 to help figure out what caused the initial issue, can you please run gcc -march=native -dM -E - </dev/null and paste the output here? Thanks.

[xcom169]

gcc -march=native -dM -E - </dev/null

define __SSP_STRONG__ 3

define DBL_MIN_EXP (-1021)

define UINT_LEAST16_MAX 0xffff

define __FLT16_HAS_QUIET_NAN__ 1

define __ATOMIC_ACQUIRE 2

define __FLT128_MAX_10_EXP__ 4932

define __FLT_MIN__ 1.17549435082228750796873653722224568e-38F

define __GCC_IEC_559_COMPLEX 2

define UINT_LEAST8_TYPE unsigned char

define __SIZEOF_FLOAT80__ 16

define __INTMAX_C(c) c ## L

define MOVBE 1

define __CHAR_BIT__ 8

define __UINT8_MAX__ 0xff

define __SCHAR_WIDTH__ 8

define __WINT_MAX__ 0xffffffffU

define ORDER_LITTLE_ENDIAN 1234

define __SIZE_MAX__ 0xffffffffffffffffUL

define __SSE4_1__ 1

define __WCHAR_MAX__ 0x7fffffff

define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_2 1

define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 1

define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_8 1

define __GCC_ATOMIC_CHAR_LOCK_FREE 2

define __GCC_IEC_559 2

define FLT32X_DECIMAL_DIG 17

define FLT_EVAL_METHOD 0

define FLT64_DECIMAL_DIG 17

define __GCC_ATOMIC_CHAR32_T_LOCK_FREE 2

define RDPID 1

define UINT_FAST64_MAX 0xffffffffffffffffUL

define SIG_ATOMIC_TYPE int

define __DBL_MIN_10_EXP__ (-307)

define FINITE_MATH_ONLY 0

define FLT32X_MAX_EXP 1024

define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_1 1

define FLT32_HAS_DENORM 1

define UINT_FAST8_MAX 0xff

define __FLT32_MAX_10_EXP__ 38

define DEC64_MAX_EXP 385

define __INT8_C(c) c

define tune_goldmont_plus 1

define INT_LEAST8_WIDTH 8

define UINT_LEAST64_MAX 0xffffffffffffffffUL

define __SHRT_MAX__ 0x7fff

define __LDBL_MAX__ 1.18973149535723176502126385303097021e+4932L

define __FLT64X_MAX_10_EXP__ 4932

define __LDBL_IS_IEC_60559__ 2

define __FLT64X_HAS_QUIET_NAN__ 1

define UINT_LEAST8_MAX 0xff

define __GCC_ATOMIC_BOOL_LOCK_FREE 2

define __LAHF_SAHF__ 1

define FLT128_DENORM_MIN

6.47517511943802511092443895822764655e-4966F128

define __UINTMAX_TYPE__ long unsigned int

define __linux 1

define __DEC32_EPSILON__ 1E-6DF

define __FLT_EVAL_METHOD_TS_18661_3__ 0

define __unix 1

define __UINT32_MAX__ 0xffffffffU

define DBL_DENORM_MIN

((double)4.94065645841246544176568792868221372e-324L)

define FLT128_MIN_EXP (-16381)

define __WINT_MIN__ 0U

define __FLT128_MIN_10_EXP__ (-4931)

define __FLT32X_IS_IEC_60559__ 2

define INT_LEAST16_WIDTH 16

define __SCHAR_MAX__ 0x7f

define FLT128_MANT_DIG 113

define WCHAR_MIN (-WCHAR_MAX - 1)

define __INT64_C(c) c ## L

define __GCC_ATOMIC_POINTER_LOCK_FREE 2

define FLT32X_MANT_DIG 53

define __FLT64X_EPSILON__ 1.08420217248550443400745280086994171e-19F64x

define __STDC_HOSTED__ 1

define DEC64_MIN_EXP (-382)

define __DBL_DIG__ 15

define __FLT32_DIG__ 6

define __FLT_EPSILON__ 1.19209289550781250000000000000000000e-7F

define __SHRT_WIDTH__ 16

define __FLT32_IS_IEC_60559__ 2

define __LDBL_MIN__ 3.36210314311209350626267781732175260e-4932L

define STDC_UTF_16 1

define __DBL_IS_IEC_60559__ 2

define __DEC32_MAX__ 9.999999E96DF

define FLT64X_DENORM_MIN

3.64519953188247460252840593361941982e-4951F64x

define CRC32 1

define FLT32X_HAS_INFINITY 1

define __INT32_MAX__ 0x7fffffff

define __FLT16_DIG__ 3

define unix 1

define __INT_WIDTH__ 32

define __SIZEOF_LONG__ 8

define STDC_IEC_559 1

define STDC_ISO_10646 201706L

define __UINT16_C(c) c

define __DECIMAL_DIG__ 21

define __STDC_IEC_559_COMPLEX__ 1

define __FLT64_EPSILON__ 2.22044604925031308084726333618164062e-16F64

define __gnu_linux__ 1

define __FLT128_IS_IEC_60559__ 2

define __FLT64X_MIN_10_EXP__ (-4931)

define __LDBL_HAS_QUIET_NAN__ 1

define FLT16_MIN_EXP (-13)

define FLT64_MANT_DIG 53

define FLT64X_MANT_DIG 64

define GNUC 12

define pie 2

define MMX 1

define XSAVES 1

define FLT_HAS_DENORM 1

define SIZEOF_LONG_DOUBLE 16

define XSAVEOPT 1

define __BIGGEST_ALIGNMENT__ 16

define PRFCHW 1

define __FLT64_MAX_10_EXP__ 308

define __FLT16_MAX_10_EXP__ 4

define __DBL_MAX__ ((double)1.79769313486231570814527423731704357e+308L)

define INT_FAST32_MAX 0x7fffffffffffffffL

define DBL_HAS_INFINITY 1

define __SSE4_2__ 1

define __SIZEOF_FLOAT__ 4

define __HAVE_SPECULATION_SAFE_VALUE 1

define DEC32_MIN_EXP (-94)

define __INTPTR_WIDTH__ 64

define FLT64X_HAS_INFINITY 1

define UINT_LEAST32_MAX 0xffffffffU

define FLT32X_HAS_DENORM 1

define INT_FAST16_TYPE long int

define MMX_WITH_SSE 1

define LDBL_HAS_DENORM 1

define __SEG_GS 1

define FLT128_HAS_INFINITY 1

define __DEC32_MIN__ 1E-95DF

define POPCNT 1

define DBL_MAX_EXP 1024

define __WCHAR_WIDTH__ 32

define __FLT32_MAX__ 3.40282346638528859811704183484516925e+38F32

define __DEC128_EPSILON__ 1E-33DL

define FLT16_DECIMAL_DIG 5

define __SSE2_MATH__ 1

define __ATOMIC_HLE_RELEASE 131072

define __PTRDIFF_MAX__ 0x7fffffffffffffffL

define __amd64 1

define __ATOMIC_HLE_ACQUIRE 65536

define LONG_LONG_MAX 0x7fffffffffffffffLL

define SIZEOF_SIZE_T 8

define FLT64X_MIN_EXP (-16381)

define SIZEOF_WINT_T 4

define LONG_LONG_WIDTH 64

define FLT32_MAX_EXP 128

define __GXX_ABI_VERSION 1017

define FLT_MIN_EXP (-125)

define __GCC_HAVE_DWARF2_CFI_ASM 1

define __INT16_MAX__ 0x7fff

define __x86_64 1

define INT_FAST64_TYPE long int

define FLT64_DENORM_MIN 4.94065645841246544176568792868221372e-324F64

define __DBL_MIN__ ((double)2.22507385850720138309023271733240406e-308L)

define CLFLUSHOPT 1

define PCLMUL 1

define FLT16_DENORM_MIN 5.96046447753906250000000000000000000e-8F16

define __FLT128_EPSILON__ 1.92592994438723585305597794258492732e-34F128

define FLT64X_NORM_MAX 1.18973149535723176502126385303097021e+4932F64x

define __SIZEOF_POINTER__ 8

define LP64 1

define __DBL_HAS_QUIET_NAN__ 1

define __FLT32X_EPSILON__ 2.22044604925031308084726333618164062e-16F32x

define DECIMAL_BID_FORMAT 1

define FLT64_MIN_EXP (-1021)

define __FLT64_MIN_10_EXP__ (-307)

define __FLT16_MIN_10_EXP__ (-4)

define FLT64X_DECIMAL_DIG 21

define __DEC128_MIN__ 1E-6143DL

define __REGISTER_PREFIX__

define __UINT16_MAX__ 0xffff

define DBL_HAS_DENORM 1

define LDBL_HAS_INFINITY 1

define __FLT32_MIN__ 1.17549435082228750796873653722224568e-38F32

define __UINT8_TYPE__ unsigned char

define XSAVE 1

define __FLT_DIG__ 6

define __NO_INLINE__ 1

define DEC_EVAL_METHOD 2

define __DEC128_MAX__ 9.999999999999999999999999999999999E6144DL

define FLT_MANT_DIG 24

define LDBL_DECIMAL_DIG 21

define VERSION "12.2.0"

define __UINT64_C(c) c ## UL

define _STDC_PREDEF_H 1

define INT_LEAST32_MAX 0x7fffffff

define __GCC_ATOMIC_INT_LOCK_FREE 2

define FLT128_MAX_EXP 16384

define FLT32_MANT_DIG 24

define __FLT16_IS_IEC_60559__ 2

define FLOAT_WORD_ORDER ORDER_LITTLE_ENDIAN

define FLT32X_MIN_EXP (-1021)

define __STDC_IEC_60559_COMPLEX__ 201404L

define __goldmont_plus 1

define FLT128_HAS_DENORM 1

define FLT32_DECIMAL_DIG 9

define __FLT128_DIG__ 33

define __INT32_C(c) c

define __DEC64_EPSILON__ 1E-15DD

define ORDER_PDP_ENDIAN 3412

define DEC128_MIN_EXP (-6142)

define INT_FAST32_TYPE long int

define linux 1

define __FLT16_MIN__ 6.10351562500000000000000000000000000e-5F16

define UINT_LEAST16_TYPE short unsigned int

define unix 1

define __SIZE_TYPE__ long unsigned int

define __UINT64_MAX__ 0xffffffffffffffffUL

define __FLT_IS_IEC_60559__ 2

define __GNUC_WIDE_EXECUTION_CHARSET_NAME "UTF-32LE"

define __FLT64X_DIG__ 18

define __INT8_TYPE__ signed char

define ELF 1

define __GCC_ASM_FLAG_OUTPUTS__ 1

define __UINT32_TYPE__ unsigned int

define __FLT_RADIX__ 2

define INT_LEAST16_TYPE short int

define __LDBL_EPSILON__ 1.08420217248550443400745280086994171e-19L

define __UINTMAX_C(c) c ## UL

define __SSE_MATH__ 1

define __FLT32X_MIN__ 2.22507385850720138309023271733240406e-308F32x

define SIG_ATOMIC_MAX 0x7fffffff

define __GCC_ATOMIC_WCHAR_T_LOCK_FREE 2

define USER_LABEL_PREFIX

define __STDC_IEC_60559_BFP__ 201404L

define SIZEOF_PTRDIFF_T 8

define RDSEED 1

define __LDBL_DIG__ 18

define __FLT64_IS_IEC_60559__ 2

define __x86_64__ 1

define FLT16_MAX_EXP 16

define DEC32_SUBNORMAL_MIN 0.000001E-95DF

define INT_FAST16_MAX 0x7fffffffffffffffL

define __GCC_CONSTRUCTIVE_SIZE 64

define __FLT64_DIG__ 15

define UINT_FAST32_MAX 0xffffffffffffffffUL

define UINT_LEAST64_TYPE long unsigned int

define __FLT16_EPSILON__ 9.76562500000000000000000000000000000e-4F16

define __FLT_HAS_QUIET_NAN__ 1

define __FLT_MAX_10_EXP__ 38

define __LONG_MAX__ 0x7fffffffffffffffL

define FLT64X_HAS_DENORM 1

define DEC128_SUBNORMAL_MIN 0.000000000000000000000000000000001E-6143DL

define FLT_HAS_INFINITY 1

define __GNUC_EXECUTION_CHARSET_NAME "UTF-8"

define UINT_FAST16_TYPE long unsigned int

define __DEC64_MAX__ 9.999999999999999E384DD

define INT_FAST32_WIDTH 64

define __CHAR16_TYPE__ short unsigned int

define __PRAGMA_REDEFINE_EXTNAME 1

define __SIZE_WIDTH__ 64

define __SEG_FS 1

define INT_LEAST16_MAX 0x7fff

define FLT16_NORM_MAX 6.55040000000000000000000000000000000e+4F16

define DEC64_MANT_DIG 16

define __INT64_MAX__ 0x7fffffffffffffffL

define FLT32_DENORM_MIN 1.40129846432481707092372958328991613e-45F32

define SIG_ATOMIC_WIDTH 32

define INT_LEAST64_TYPE long int

define __INT16_TYPE__ short int

define INT_LEAST8_TYPE signed char

define __FLT16_MAX__ 6.55040000000000000000000000000000000e+4F16

define __STDC_VERSION__ 201710L

define __SIZEOF_INT__ 4

define DEC32_MAX_EXP 97

define INT_FAST8_MAX 0x7f

define __FLT128_MAX__ 1.18973149535723176508575932662800702e+4932F128

define __INTPTR_MAX__ 0x7fffffffffffffffL

define linux 1

define __FLT64_HAS_QUIET_NAN__ 1

define SGX 1

define __FLT32_MIN_10_EXP__ (-37)

define SSSE3 1

define __FLT32X_DIG__ 15

define RDRND 1

define __PTRDIFF_WIDTH__ 64

define LDBL_MANT_DIG 64

define FLT64_HAS_INFINITY 1

define __FLT64X_MAX__ 1.18973149535723176502126385303097021e+4932F64x

define FLT16_HAS_INFINITY 1

define SIG_ATOMIC_MIN (-SIG_ATOMIC_MAX - 1)

define code_model_small 1

define __GCC_ATOMIC_LONG_LOCK_FREE 2

define DEC32_MANT_DIG 7

define FLT16_MANT_DIG 11

define __INTPTR_TYPE__ long int

define __UINT16_TYPE__ short unsigned int

define __WCHAR_TYPE__ int

define pic 2

define __UINTPTR_MAX__ 0xffffffffffffffffUL

define INT_FAST64_WIDTH 64

define __goldmont_plus__ 1

define INT_FAST64_MAX 0x7fffffffffffffffL

define __GCC_ATOMIC_TEST_AND_SET_TRUEVAL 1

define FLT_NORM_MAX 3.40282346638528859811704183484516925e+38F

define FLT32_HAS_INFINITY 1

define FLT64X_MAX_EXP 16384

define UINT_FAST64_TYPE long unsigned int

define __INT_MAX__ 0x7fffffff

define SHA 1

define __INT64_TYPE__ long int

define FLT_MAX_EXP 128

define ORDER_BIG_ENDIAN 4321

define DBL_MANT_DIG 53

define __SIZEOF_FLOAT128__ 16

define INT_LEAST64_MAX 0x7fffffffffffffffL

define __GCC_ATOMIC_CHAR16_T_LOCK_FREE 2

define __DEC64_MIN__ 1E-383DD

define __WINT_TYPE__ unsigned int

define UINT_LEAST32_TYPE unsigned int

define __SIZEOF_SHORT__ 2

define FLT32_NORM_MAX 3.40282346638528859811704183484516925e+38F32

define SSE 1

define LDBL_MIN_EXP (-16381)

define __FLT64_MAX__ 1.79769313486231570814527423731704357e+308F64

define __WINT_WIDTH__ 32

define INT_LEAST8_MAX 0x7f

define INT_LEAST64_WIDTH 64

define LDBL_MAX_EXP 16384

define __FLT32X_MAX_10_EXP__ 308

define __SIZEOF_INT128__ 16

define __FLT64X_IS_IEC_60559__ 2

define __LDBL_MAX_10_EXP__ 4932

define __ATOMIC_RELAXED 0

define __DBL_EPSILON__ ((double)2.22044604925031308084726333618164062e-16L)

define FLT32_MIN_EXP (-125)

define __FLT128_MIN__ 3.36210314311209350626267781732175260e-4932F128

define _LP64 1

define __UINT8_C(c) c

define FLT64_MAX_EXP 1024

define INT_LEAST32_TYPE int

define SIZEOF_WCHAR_T 4

define __UINT64_TYPE__ long unsigned int

define __GNUC_PATCHLEVEL__ 0

define FLT128_NORM_MAX 1.18973149535723176508575932662800702e+4932F128

define amd64 1

define FLT64_NORM_MAX 1.79769313486231570814527423731704357e+308F64

define __FLT128_HAS_QUIET_NAN__ 1

define __INTMAX_MAX__ 0x7fffffffffffffffL

define INT_FAST8_TYPE signed char

define __FLT64X_MIN__ 3.36210314311209350626267781732175260e-4932F64x

define GNUC_STDC_INLINE 1

define FLT64_HAS_DENORM 1

define __FLT32_EPSILON__ 1.19209289550781250000000000000000000e-7F32

define FLT16_HAS_DENORM 1

define DBL_DECIMAL_DIG 17

define STDC_UTF_32 1

define INT_FAST8_WIDTH 8

define FXSR 1

define __FLT32X_MAX__ 1.79769313486231570814527423731704357e+308F32x

define DBL_NORM_MAX

((double)1.79769313486231570814527423731704357e+308L)

define __BYTE_ORDER ORDER_LITTLE_ENDIAN__

define __GCC_DESTRUCTIVE_SIZE 64

define __INTMAX_WIDTH__ 64

define __UINT32_C(c) c ## U

define FLT_DENORM_MIN 1.40129846432481707092372958328991613e-45F

define __INT8_MAX__ 0x7f

define __LONG_WIDTH__ 64

define PIC 2

define UINT_FAST32_TYPE long unsigned int

define FLT32X_NORM_MAX 1.79769313486231570814527423731704357e+308F32x

define __CHAR32_TYPE__ unsigned int

define __FLT_MAX__ 3.40282346638528859811704183484516925e+38F

define SSE2 1

define __INT32_TYPE__ int

define XSAVEC 1

define __SIZEOF_DOUBLE__ 8

define __FLT_MIN_10_EXP__ (-37)

define __FLT64_MIN__ 2.22507385850720138309023271733240406e-308F64

define INT_LEAST32_WIDTH 32

define __INTMAX_TYPE__ long int

define DEC128_MAX_EXP 6145

define FSGSBASE 1

define __FLT32X_HAS_QUIET_NAN__ 1

define __ATOMIC_CONSUME 1

define __GNUC_MINOR__ 2

define INT_FAST16_WIDTH 64

define __UINTMAX_MAX__ 0xffffffffffffffffUL

define PIE 2

define FLT32X_DENORM_MIN 4.94065645841246544176568792868221372e-324F32x

define __DBL_MAX_10_EXP__ 308

define LDBL_DENORM_MIN 3.64519953188247460252840593361941982e-4951L

define __INT16_C(c) c

define STDC 1

define AES 1

define __PTRDIFF_TYPE__ long int

define __ATOMIC_SEQ_CST 5

define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 1

define PTWRITE 1

define __FLT32X_MIN_10_EXP__ (-307)

define __UINTPTR_TYPE__ long unsigned int

define DEC64_SUBNORMAL_MIN 0.000000000000001E-383DD

define DEC128_MANT_DIG 34

define __LDBL_MIN_10_EXP__ (-4931)

define SIZEOF_LONG_LONG 8

define FLT128_DECIMAL_DIG 36

define __GCC_ATOMIC_LLONG_LOCK_FREE 2

define __FLT32_HAS_QUIET_NAN__ 1

define FLT_DECIMAL_DIG 9

define UINT_FAST16_MAX 0xffffffffffffffffUL

define LDBL_NORM_MAX 1.18973149535723176502126385303097021e+4932L

define __GCC_ATOMIC_SHORT_LOCK_FREE 2

define SSE3 1

define UINT_FAST8_TYPE unsigned char

define __ATOMIC_ACQ_REL 4

define __ATOMIC_RELEASE 3

On Sat, 21 Jan 2023 at 19:15, bentorkington @.***> wrote:

@xcom169 https://github.com/xcom169 to help figure out what caused the initial issue, can you please run gcc -march=native -dM -E - </dev/null and paste the output here? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/bentorkington/sf2ww/issues/6#issuecomment-1399303874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2G2ROFD3QCTAJQNZEGDLWTQRTFANCNFSM6AAAAAAUBOQY6I . You are receiving this because you were mentioned.Message ID: @.***>

[xcom169]

Thanks! Installing cmocka helped.

[bentorkington]

@xcom169 thanks for that Timár

Looks like compilers aren't consistent about defining __LITTLE_ENDIAN__ so I need to use a more reliable way