search

benvanstaveren / Mojolicious-Plugin-Authentication

A plugin to make authentication a bit easier
http://search.cpan.org/dist/Mojolicious-Plugin-Authentication/
Other
20 stars 17 forks source link

Async #31

Closed mohawk2 closed 4 years ago

mohawk2 commented 4 years ago

As discussed. If you like it, it closes #30.

jjatria commented 4 years ago

I've released this as 1.34-TRIAL to CPAN. I'll bump to 1.35 in a week or so.

jjatria commented 3 years ago

@mohawk2 As mentioned in #25, the TRIAL release bump got delayed because of some failing tests that died with

Can't use string ("Mojo::Promise") as a HASH ref

Could the cause of that failure be in the

-$app->hook(before_dispatch => $user_loader_sub) if($autoload_user);
+$app->hook(before_dispatch => $user_loader_sub_p) if $autoload_user;

of this change?

mohawk2 commented 3 years ago

It's conceivable! But it's hard to be sure. The test report doesn't tell us what version of Mojolicious is installed, because the distro currently only gives a dep on Mojo::Base etc, which doesn't seem to be in line with Mojolicious policy (which I infer says you should dep on Mojolicious, other modules are unversioned). Could you adjust that and make another release so we can track this thing down?

jjatria commented 3 years ago

Oh, good catch. I've switched to specifying the dependencies with a cpanfile and pushed 1.35-TRIAL to CPAN. Let's see what the tests say now :popcorn:

Thanks for chasing this up!