Closed benvinegar closed 7 months ago
Attention: Patch coverage is 90.90909%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 74.25%. Comparing base (
5f37d61
) to head (c5589b2
).
Files | Patch % | Lines |
---|---|---|
app/routes/dashboard.tsx | 90.14% | 7 Missing :warning: |
app/analytics/query.ts | 91.66% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Refs #3
This is different from "last 24 hours" because it only shows you data from
00:00
this morning in the user's local timezone.Does a bunch of refactoring to make this possible:
tz
getViewsGroupedByInterval
(query.ts) now takes an explicit start date time, instead of calculating everything as offsets from day intervals (more flexible)dashboard.tsx
loader function (a little messy)Screenshot:
Note I haven't done much testing when there's 0 datapoints, e.g. if you asked for "today" at 12:43 AM your local time.