Open saracarl opened 10 months ago
Working on some options for styling the tag cloud better. I could use some feedback on these, @anabeabas and @benwbrum:
With justify-content: space-evenly;
With justify-content: space-between;
With justify-content: space-around;
With justify-content: center;
@saracarl I think justify-content: space-evenly;
looks the best.
Side note: the tags look too close together. Is there a way to fix the spacing vertically? And the capsules look a bit too small/tight for the text. Maybe we could also do a slightly thicker border?
Agreed on the justify-content: space-evenly;
Also tried this one:
Because it was easy to implement, but the bullets are slightly wonky on the spacing.
I'm going to go back to justify-content: space-evenly;
and see if I can make the vertical spacing better.
Ok. Here's my newest revision for review, @anabeabas and @benwbrum :+1:
I'd still like to color code the buttons by weight, but that's a harder problem to solve than just the spacing.
@saracarl Wow, this looks so much better already! My only comment is the bottom row of tags are a bit too far apart. Hmm, I wonder what the color gradient would look like if we did the color code by weight.
500 error editing and saving a tag:
I, [2024-02-06T20:37:32.026181 #10995] INFO -- : Started PATCH "/admin/tags/719/update" for 136.62.254.224 at 2024-02-06 20:37:32 +0000
I, [2024-02-06T20:37:32.027936 #10995] INFO -- : Processing by AdminController#update_tag as HTML
I, [2024-02-06T20:37:32.028168 #10995] INFO -- : Parameters: {"authenticity_token"=>"1XLICnORz5iKoHPGWFSHSsP/H/12/XpeCdcsZEfGdrSjQUZvQgAI4shiBoYzMoC+LGUuQhzk9ln0ixuKnhOQ+w==", "tag"=>{"ai_text"=>"Afric
an-American History", "tag_type"=>"subject", "canonical"=>"1"}, "save"=>"", "tag_id"=>"719"}
F, [2024-02-06T20:37:32.050782 #10995] FATAL -- :
NoMethodError (undefined method `update_attributes' for #<Tag:0x00007f8a8bf74370>
Did you mean? update_attribute):
[ ] This is hard to read:
Because our tags are multiple words, and many of our tags are the same size. Even just the first line: African-American History Agriculture and Farming Arts is hard to visually parse. The solution is the one @anabeabas found -- use a more capsule style UI for each tag.
We may also want to play with spacing. Notice how the example is justified.
[x] Zines keyword doesn't show any collections: https://fromthepage.com/browse_tag/Zines. Maybe because it's a trial. Or because it's near complete. (Looked at the code. Probably because it's near complete.) So we need to control the tag display more to use this logic. But zines is not in the tag cloud at this point, so not important.
[x] Can we combine the show action and the edit action for tags to just take us to 1 page?
[ ] Should we show completed projects for tags? (I think so, but lower on the page. Here's an example collection that doesn't show up, but needs review: https://fromthepage.com/collection/show?collection_id=660)
[ ] https://fromthepage.com/newfindaproject takes a long time to load. Any way we can speed that up?
[ ] As an admin, I don't have a way to take a tag off of a collection. Only the project owner can. I think we should have a way to let admins remove collections from a tag or search for collections to add to a tag. I think the tag show view is the right one for this.
[ ] What about inactive projects?
[ ] I'd like to merge "Natural History" into "Natural Sciences", but I can't because we don't think it's a possible duplicate. We should be able to search for a tag to merge into. Or I guess we could do this manually by editing the tags on that collection? Not as clean or as future proof. Also shows up on this tag, which should match the same tag without the html markup dirtiness.
[ ] How are we ordering collections on the page for each tag? Looking at this one while I'm thinking about this: https://fromthepage.com/browse_tag/Slavery
[ ] I didn't like Finding Aids and Catalogs, so I made it non-canonical. Let's discuss.
[ ] We don't have a "cemetery" tag. We do have a suggested "African American Cemetery" tag. Let's discuss. Maybe a UI for adding a canonical tag?
[ ] US Presidents as a tag is over-matching. (Did we have any in our training data?) Let's discuss, but I'd be tempted to non-canonical it. (But my use of "training data" here suggests perhaps we should fine tune this interaction with ChatGPT.)
[ ] I'm worried that we don't have any individual states. Were they in our canonical list? But we have so many genealogists and local historians, this seems like an obvious way to slice and dice.
[ ] I think we should add the institution on the tag's project listing page.