benwbrum / fromthepage

FromThePage is a wiki-like application for crowdsourcing transcription of handwritten documents.
http://fromthepage.com
GNU Affero General Public License v3.0
170 stars 50 forks source link

tag cloud issues #3839

Open saracarl opened 10 months ago

saracarl commented 10 months ago
saracarl commented 10 months ago

Working on some options for styling the tag cloud better. I could use some feedback on these, @anabeabas and @benwbrum:

With justify-content: space-evenly; image

With justify-content: space-between; image

With justify-content: space-around; image

With justify-content: center; image

anabeabas commented 10 months ago

@saracarl I think justify-content: space-evenly; looks the best.

Side note: the tags look too close together. Is there a way to fix the spacing vertically? And the capsules look a bit too small/tight for the text. Maybe we could also do a slightly thicker border?

saracarl commented 10 months ago

Agreed on the justify-content: space-evenly;

Also tried this one:

image

Because it was easy to implement, but the bullets are slightly wonky on the spacing.

I'm going to go back to justify-content: space-evenly; and see if I can make the vertical spacing better.

saracarl commented 10 months ago

Ok. Here's my newest revision for review, @anabeabas and @benwbrum :+1: image I'd still like to color code the buttons by weight, but that's a harder problem to solve than just the spacing.

anabeabas commented 10 months ago

@saracarl Wow, this looks so much better already! My only comment is the bottom row of tags are a bit too far apart. Hmm, I wonder what the color gradient would look like if we did the color code by weight.

saracarl commented 7 months ago
saracarl commented 7 months ago

500 error editing and saving a tag:

I, [2024-02-06T20:37:32.026181 #10995]  INFO -- : Started PATCH "/admin/tags/719/update" for 136.62.254.224 at 2024-02-06 20:37:32 +0000
I, [2024-02-06T20:37:32.027936 #10995]  INFO -- : Processing by AdminController#update_tag as HTML
I, [2024-02-06T20:37:32.028168 #10995]  INFO -- :   Parameters: {"authenticity_token"=>"1XLICnORz5iKoHPGWFSHSsP/H/12/XpeCdcsZEfGdrSjQUZvQgAI4shiBoYzMoC+LGUuQhzk9ln0ixuKnhOQ+w==", "tag"=>{"ai_text"=>"Afric
an-American History", "tag_type"=>"subject", "canonical"=>"1"}, "save"=>"", "tag_id"=>"719"}
F, [2024-02-06T20:37:32.050782 #10995] FATAL -- :   
NoMethodError (undefined method `update_attributes' for #<Tag:0x00007f8a8bf74370>
Did you mean?  update_attribute):