search

benweet / stackedit

In-browser Markdown editor
https://stackedit.io/
Apache License 2.0
21.49k stars 2.7k forks source link

Attempting to connect a github account is failing with a 400 error #1763

Closed lightman76 closed 2 years ago

lightman76 commented 2 years ago

The 400 error points to this page https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ .

This call to get the user info is using a deprecated authentication method (passing access_token param). Updated to use the existing request method which uses the header based authentication.

I apologize, I don't have the required clientId/secret to test this fix, and not sure if it has to be deployed on something other than localhost to test it. Hopefully this is a simple change to test.

lightman76 commented 2 years ago

Had some time to figure out the github credentials and set it up. This didn't work and I found another pull request already pending which fixes this issue.