search

benweier / blizzard.js

A promise-based Node.JS library for the Blizzard Battle.net Community Platform API
MIT License
145 stars 29 forks source link

8.2 ItemData endpoint #95

Closed AlexZeDim closed 4 years ago

AlexZeDim commented 5 years ago

This PR is relevant to Issue#92 and represents the second path of solving a problem. So if this one will be approved, then more to come. P.S. Now with 100% code coverage

codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.43%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage     100%   99.56%   -0.44%     
==========================================
  Files           9        9              
  Lines         227      229       +2     
  Branches       37       38       +1     
==========================================
+ Hits          227      228       +1     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 99.02% <50%> (-0.98%) :arrow_down:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.43%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage     100%   99.56%   -0.44%     
==========================================
  Files           9        9              
  Lines         227      229       +2     
  Branches       37       38       +1     
==========================================
+ Hits          227      228       +1     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 99.02% <50%> (-0.98%) :arrow_down:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.43%. The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage     100%   99.56%   -0.44%     
==========================================
  Files           9        9              
  Lines         227      229       +2     
  Branches       37       38       +1     
==========================================
+ Hits          227      228       +1     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 99.02% <50%> (-0.98%) :arrow_down:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up:
codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         227    229    +2     
  Branches       37     38    +1     
=====================================
+ Hits          227    229    +2
Impacted Files Coverage Δ
lib/endpoints.js 100% <ø> (ø) :arrow_up:
lib/wow.js 100% <100%> (ø) :arrow_up: