search

benwiley4000 / cassette

📼 A flexible media player component library for React that requires no up-front config
https://benwiley4000.github.io/cassette/styleguide
MIT License
184 stars 28 forks source link

Investigate: why are we guarding against currentTime changes during track load? #371

Closed benwiley4000 closed 5 years ago

benwiley4000 commented 5 years ago

Noticed while reviewing the problem/solution for https://github.com/benwiley4000/cassette/pull/370

I can't really figure out why I added this check to enforce currentTime during a track load. Is this even possible?

https://github.com/benwiley4000/cassette/blob/5f99ee29fd0bdea42aa92704fec5fcb3f4f5081a/packages/core/src/PlayerContextProvider.js#L689

I don't want to just remove it without investigating what's even possible. Looking at the spec or browser implementations might help.

benwiley4000 commented 5 years ago

Closed in #392.