search

benwiley4000 / cassette

📼 A flexible media player component library for React that requires no up-front config
https://benwiley4000.github.io/cassette/styleguide
MIT License
184 stars 28 forks source link

Add track duration #372

Closed danielr18 closed 5 years ago

danielr18 commented 5 years ago

Solves #363. Should support time strings and numbers as duration

benwiley4000 commented 5 years ago

Can we also update the track proptype? https://github.com/danielr18/cassette/blob/5cd5b1c6a0644bbb105b52ffd26b75cebc00f7cf/packages/core/src/PlayerPropTypes.js#L76

Duration can be required.. we also should add startingTime.

danielr18 commented 5 years ago

Yes, added it, I don't think duration needs to be required though.

benwiley4000 commented 5 years ago

I'll follow your judgment. Thanks!

benwiley4000 commented 5 years ago

Released in v2.0.0-alpha.27 (has breaking changes, see the release notes)