benwiley4000 / cassette

📼 A flexible media player component library for React that requires no up-front config
https://benwiley4000.github.io/cassette/styleguide
MIT License
184 stars 28 forks source link

volume control fix on scroll #430

Closed RobinGiel closed 4 years ago

RobinGiel commented 4 years ago

According to MDN: For cross-browser compatibility, use window.pageYOffset instead of window.scrollY. Additionally, older versions of Internet Explorer (< 9) do not support either property and must be worked around by checking other non-standard properties. A fully compatible example:

`var supportPageOffset = window.pageXOffset !== undefined; var isCSS1Compat = ((document.compatMode || "") === "CSS1Compat");

var x = supportPageOffset ? window.pageXOffset : isCSS1Compat ? document.documentElement.scrollLeft : document.body.scrollLeft; var y = supportPageOffset ? window.pageYOffset : isCSS1Compat ? document.documentElement.scrollTop : document.body.scrollTop; `

https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY#Notes

Tested on Firefox, Chrome, Safari, Edge and Internet Explore

benwiley4000 commented 4 years ago

I will try to make a new release tonight.. remind me if I forget. Thanks again!

RobinGiel commented 4 years ago

@benwiley4000 just a reminder for the release :-)

benwiley4000 commented 4 years ago

Sorry for the radio silence. I've had a crazy week but I really will try to do this tonight. Setting a reminder.

Ben

Le ven. 20 sept. 2019 17 h 28, Robin Giel notifications@github.com a écrit :

@benwiley4000 https://github.com/benwiley4000 just a reminder for the release :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/benwiley4000/cassette/pull/430?email_source=notifications&email_token=ADHOD3L27K4AVUGUVCCJ4W3QKU577A5CNFSM4IXHU6BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7H5M2Q#issuecomment-533714538, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHOD3OIYMWL4P4WSGYYCULQKU577ANCNFSM4IXHU6BA .

benwiley4000 commented 4 years ago

Does this close #407?

benwiley4000 commented 4 years ago

@RobinGiel I just published v2.0.0-beta.4! Thanks. And sorry again for the wait.