search

benwiley4000 / react-gif-player

📽 A GIF component that moves when YOU want it to!
https://benwiley4000.github.io/react-gif-player/
MIT License
94 stars 32 forks source link

fix(prop-types): use proptypes from a different package rather than f… #15

Closed nicubarbaros closed 7 years ago

nicubarbaros commented 7 years ago

Add PropTypes in order to avoid React 15 warning.

benwiley4000 commented 7 years ago

Awesome thanks!

nicubarbaros commented 6 years ago

Cheers!

benwiley4000 commented 6 years ago

@nicubarbaros I just noticed this (my bad for not catching it), but I'd prefer you not correct "linting errors" like quote style and function spacing - it adds a whole bunch of noise to the diff, and it's not what I wanted either! :wink:

nicubarbaros commented 6 years ago

@benwiley4000 I am very sorry. ;(

benwiley4000 commented 6 years ago

@nicubarbaros hey don't worry about it! I thought it was good enough to merge. :)

I just thought I would let you know for future reference - concise PRs will make open source maintainers happy. :D

benwiley4000 commented 6 years ago

And thanks again for the contribution :)