search

benwiley4000 / react-gif-player

📽 A GIF component that moves when YOU want it to!
https://benwiley4000.github.io/react-gif-player/
MIT License
94 stars 32 forks source link

webpack umd globalObject fix #31

Closed mohitmayank closed 4 years ago

mohitmayank commented 5 years ago

Fixes https://github.com/benwiley4000/react-gif-player/issues/30

benwiley4000 commented 5 years ago

@mohitmayank sorry, just now getting to this! Thanks for the fix. On another project we did this: https://github.com/benwiley4000/cassette/blob/872e5960ed77e001961b89699f32aa8b3c98fc9e/getPackageWebpackConfig.js#L108

Would that work ok? I might be more comfortable with that as the fix since I know it works.

benwiley4000 commented 5 years ago

@mohitmayank could you let me know what you think?

eg9y commented 4 years ago

stumbled on this issue as well. Would be cool if this gets merged :)

mohitmayank commented 4 years ago

@benwiley4000 i just realised that this this got missed by me. Fix you mentioned should also fix this.

benwiley4000 commented 4 years ago

Let's keep the PR open just so I don't forget to address it - my backlog has been a bit crowded. I'll try to get to it in the next several days if time permits, or feel free to make a new PR! Thanks

mohitmayank commented 4 years ago

Superseded by https://github.com/benwiley4000/react-gif-player/pull/33