search

benwiley4000 / react-gif-player

📽 A GIF component that moves when YOU want it to!
https://benwiley4000.github.io/react-gif-player/
MIT License
94 stars 32 forks source link

React 17 update? #37

Open pwnedev opened 2 years ago

pwnedev commented 2 years ago

Hey there!

Are you going to update this package to work with react 17?

Thanks in advance!

derekantrican commented 10 months ago

Or even react 18 at this point

benwiley4000 commented 10 months ago

I think it works with any react version, is npm refusing to install because of the peer dependency?

taktran commented 9 months ago

I've created a PR to update for React 18: https://github.com/benwiley4000/react-gif-player/pull/39. Didn't support 17 tho, but feel free to comment on it.

@benwiley4000 The v0.4.2 built files did work with React 18, but the whole build/dev pipeline didn't, which makes it difficult to install in another project, so I made quite a few upgrades to the dependencies too.

benwiley4000 commented 9 months ago

Thanks, I responded in the PR.

On Wed, Jan 24, 2024 at 6:52 AM Tak Tran @.***> wrote:

I've created a PR to update for React 18: #39 https://github.com/benwiley4000/react-gif-player/pull/39. Didn't support 17 tho, but feel free to comment on it.

@benwiley4000 https://github.com/benwiley4000 The v0.4.2 built files did work with React 18, but the whole build/dev pipeline didn't, which makes it difficult to install in another project, so I made quite a few upgrades to the dependencies too.

— Reply to this email directly, view it on GitHub https://github.com/benwiley4000/react-gif-player/issues/37#issuecomment-1907976581, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHOD3M4JMDQJG7NZZ2JEP3YQDYXFAVCNFSM5MFHMEXKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJQG44TONRVHAYQ . You are receiving this because you were mentioned.Message ID: @.***>