benwilkins / AutoMin

AutoMin is an ExpressionEngine module and extension that automates the combination and compression of your source files and currently supports CSS, JavaScript, LESS, and HTML compression.
http://devot-ee.com/add-ons/automin
23 stars 5 forks source link

Not all java has been compressed #14

Closed gfive closed 12 years ago

gfive commented 12 years ago

I Updated Automin from 2.0 to 2.1.1 (removed the hooks and so on, and to be sure. Deinstalled and installed again) After changing Tag attributes to the new version, CSS is compressing like a charm, as always. JS: Some will and some won’t combine/compress. When using 2.0 the same files compressed just fine. Same for relative paths, the compressed js works for two segments in the url (domain.com/site/example but not on the third or more like domain.com/site/example/tags/tag than the js stops working What has changed? What could I do, except downgrading to version 2.0

Kind regards, Martijn

bunchjesse commented 12 years ago

Maybe clear your template cache?

Sent from my iPhone

On Apr 4, 2012, at 11:15, gfivereply@reply.github.com wrote:

I Updated Automin from 2.0 to 2.1.1 (removed the hooks and so on, and to be sure. Deinstalled and installed again) After changing Tag attributes to the new version, CSS is compressing like a charm, as always. JS: Some will and some won’t combine/compress. When using 2.0 the same files compressed just fine. Same for relative paths, the compressed js works for two segments in the url (domain.com/site/example but not on the third or more like domain.com/site/example/tags/tag than the js stops working What has changed? What could I do, except downgrading to version 2.0

Kind regards, Martijn


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14

gfive commented 12 years ago

Hello, Also tried that, no luck.

Hmm Guess I will downgrade to 2.0... now hope that I find that version on my comp :-)

On Apr 4, 2012, at 6:34 PM, Jesse Bunch wrote:

Maybe clear your template cache?

Sent from my iPhone

On Apr 4, 2012, at 11:15, gfivereply@reply.github.com wrote:

I Updated Automin from 2.0 to 2.1.1 (removed the hooks and so on, and to be sure. Deinstalled and installed again) After changing Tag attributes to the new version, CSS is compressing like a charm, as always. JS: Some will and some won’t combine/compress. When using 2.0 the same files compressed just fine. Same for relative paths, the compressed js works for two segments in the url (domain.com/site/example but not on the third or more like domain.com/site/example/tags/tag than the js stops working What has changed? What could I do, except downgrading to version 2.0

Kind regards, Martijn


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14#issuecomment-4957486

gfive commented 12 years ago

I noticed that I had version 1.3.1 working not 2.0. Hope there will be a fix soon.

bunchjesse commented 12 years ago

Can you paste in the contents of your exp:automin:js tag(s)? I want to see what you're sending it.

gfive commented 12 years ago

As it is now, with AutoMin 2.0 (compresses/combine all as should be)

{exp:automin:js type="text/javascript"}

{/exp:automin:js}

{exp:automin:js type="text/javascript"}

{/exp:automin:js}

{exp:automin:js type="text/javascript"}

{/exp:automin:js}

{if segment_1 == "help" } {exp:automin:js type="text/javascript"}

{/exp:automin:js} {/if}

{exp:automin:js type="text/javascript"}

{/exp:automin:js}

On Apr 5, 2012, at 3:35 PM, Jesse Bunch wrote:

Can you paste in the contents of your exp:automin:js tag(s)? I want to see what you're sending it.


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14#issuecomment-4976490

bunchjesse commented 12 years ago

And none of this works with 2.1.1? Do you have a test environment that I could access with 2.1.1 installed?

gfive commented 12 years ago

Pieces of the list I mailed you will combine/compress in 2.1.1

of the 6 blocks of javascript about 3 will compress/combine, others just show the java code like

Sorry I don't have a test setup, just downgraded from 2.1.1 to 2.0 Working an a live server but EE turned off...

On Apr 5, 2012, at 4:10 PM, Jesse Bunch wrote:

And none of this works with 2.1.1? Do you have a test environment that I could access with 2.1.1 installed?


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14#issuecomment-4977144

gfive commented 12 years ago

Not sure if you have time, but I could upgrade again (pfff :-) )

Some tech specs: Running Mac Os X 10.7.3 Server (production webserver) php 5.3.8 EE 2.4

AutoMin files are written to folder and requested from URL, example: Path: /home/example/public_html/static/core Url: http://static.example.com/core

On Apr 5, 2012, at 4:10 PM, Jesse Bunch wrote:

And none of this works with 2.1.1? Do you have a test environment that I could access with 2.1.1 installed?


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14#issuecomment-4977144

bunchjesse commented 12 years ago

Sounds like AutoMin is running into an error and is returning your original javascript tags for safety. There should be an error in your template debugger that says what happened.

When you get a chance, please upgrade AutoMin again and turn template debugging on in EE. Then copy the template log and paste it here.

gfive commented 12 years ago

I will, thanks. (due to the time difference I think it will be tomorrow that I will upgrade to 2.1.1)

On Apr 5, 2012, at 4:32 PM, Jesse Bunch wrote:

Sounds like AutoMin is running into an error and is returning your original javascript tags for safety. There should be an error in your template debugger that says what happened.

When you get a chance, please upgrade AutoMin again and turn template debugging in in EE. Then copy the template log and paste it here.


Reply to this email directly or view it on GitHub: https://github.com/bunchjesse/AutoMin/issues/14#issuecomment-4977563

bunchjesse commented 12 years ago

Closing this due to no response. Please submit a new issue if this persists.