Changed service provider register method

benwilkins / laravel-fcm-notification

Laravel FCM (Firebase Cloud Messaging) Notification Channel

MIT License

213 stars 91 forks source link

Changed service provider register method #40

Closed Exidus1 closed 5 years ago

Exidus1 commented 5 years ago

Changed the way the FcmChannel is registered, because the previous method was in conflict with official Laravel Nexmo notification channel (laravel/nexmo-notification-channel). It was somehow preventing the initialization of nexmo channel, throwing exception "Driver [nexmo] not supported" when trying to use the nexmo channel. This fixed the problem and both channels now work.

Solution is based on this commit that is in itself based on this one.

Requires Laravel 5.7+

railken commented 5 years ago

@benwilkins composer.json hasn't been updated with the mininum requirement for laravel and my application (laravel 5.6) stopped to work after this merge

benwilkins commented 5 years ago

@railken Please submit a PR with the updated composer and I'll merge it in.