benwilkins / laravel-fcm-notification

Laravel FCM (Firebase Cloud Messaging) Notification Channel
MIT License
213 stars 91 forks source link

Support Laravel ^6.0 #46

Closed ankurk91 closed 5 years ago

ankurk91 commented 5 years ago

Laravel 6 will be released on Sep 3.

I was wondering why Travis-CI was not triggered for this PR. Please enable travis-ci for this repo.

Laravel 6 will be a LTS release, so i have dropped all previous version support.

ankurk91 commented 5 years ago

@benwilkins You can see travis-ci results here https://travis-ci.com/ankurk91/laravel-fcm-notification

ankurk91 commented 5 years ago

@benwilkins I would be great if we can get Laravel 6.0 support, since it has been released.

Thanks

aaronhuisinga commented 5 years ago

Waiting for this package to support Laravel 6 before we can upgrade as well!

benwilkins commented 5 years ago

@ankurk91 This PR wouldn't be backwards compatible with L5.5. Why remove that functionality and not just add 6.0 as an option?

ankurk91 commented 5 years ago

@benwilkins I have updated the PR to allow Laravel 5.3+, have a look. I think it is good time to remove support for 5.3 and 5.4.