search

benwinding / command-pal

The hackable command palette for the web, inspired by Visual Studio Code.
https://benwinding.github.io/command-pal/docs
MIT License
75 stars 8 forks source link

bug: using enter to select menu item now clears search box #29

Closed rouilj closed 1 year ago

rouilj commented 1 year ago

Type some characters to select a command and then type enter to execute it. The palette closes. When you re-open the palette, the search term you typed is still present and filtering the command list.

I expect the search term to be cleared similar to aborting with escape.

I am not sure if this is intentional or not, but I consider it a bug. I could be convinced it is a feature to allow power users to repeat the command by hitting return, open palette, hit return again etc. If so it needs to be documented as such.

benwinding commented 1 year ago

Can't reproduce, but the bug might be present in another browser, so LGTM 👌

rouilj commented 1 year ago

Interesting. I saw it with firefox and chrome as well when running a home built version. I don't remember if it happened before I upgraded fuse or hotkey though.

Since you applied the patch you may never see the issue 8-).