benwinding / newsit

Chrome Extension for Hacker News and Reddit Links
https://newsit.benwinding.com
MIT License
26 stars 1 forks source link

☐ Hide [+] When No Results: _found_ results maybe be hidden until after the box to hide _no_ results is checked ☑ then un-checked ☐ #9

Closed grahamperrin closed 3 years ago

grahamperrin commented 3 years ago

Firefox 88.0.1

https://drewdevault.com/2021/04/26/Cryptocurrency-is-a-disaster.html for example, I do get a result when I use Newsit in isolation, in a test profile.

Since I don't know when, I no longer get results in my heavily extended default profile. There's no icon, of any sort, after actively checking a page.

Please, what type of extension might be in conflict?

Can I methodically identify a conflict without disabling ranges of extensions?

grahamperrin commented 3 years ago

Chromium 90.0.4430.93

The same symptom, no icon after clicking Check Current Page.

Tested:

image

I have fewer extensions with Chromium.


If there is an extensions conflict, maybe it'll be useful to tell what (a) my default profile and (b) Chromium have in common …

benwinding commented 3 years ago

Hi @grahamperrin,

Unfortunately I can't determine what is conflicting from that information.

I would recommend switching off extensions one by one in the manage extensions section in chrome, then seeing which ones block the newsit content icons.

Also, I like those articles, very interesting read and discussions!

Let me know how you go and I can see how to fix it. Cheers, Ben

grahamperrin commented 3 years ago

I'm no longer certain of an extensions conflict.

Chromium 90.0.4430.212 (Official Build) (64-bit) on FreeBSD CURRENT-14.0 with Newsit 2.0.4 alone enabled:

Tested:

benwinding commented 3 years ago

Thanks for responding and trying that. It doesn't seem to be the versioning or OS, rather a bug in Newsit when some options are enabled.

It can be replicated like this (video below)

Peek 2021-05-23 13-58

The "Hide [+] when no results" seems to be broken, I'll try and fix it in the next few days.

Cheers, Ben

grahamperrin commented 3 years ago

Thanks!

If it helps to diagnose a root cause, it's likely that I never opted to hide no results in Chromium:

grahamperrin commented 3 years ago

Hmm. Two examples.

https://drewdevault.com/2021/04/26/Cryptocurrency-is-a-disaster.html

https://www.devever.net/~hl/freenode_abuse

For myself, I'm not bothered by the edge case (if that's what it is) in Chromium.

benwinding commented 3 years ago

Hi @grahamperrin, Should be fixed in version 2.0.5 currently being deployed. Let me know if there's any issues. Cheers, Ben