benwinding / ngx-filemanager

File manager for Angular
https://benwinding.github.io/ngx-filemanager/
MIT License
9 stars 9 forks source link

Add User and Group for set permissions #18

Closed congweibai closed 3 years ago

congweibai commented 3 years ago

Hi Ben,

As currently users and groups are mixed, I would like to tell difference between them. My solution is to push a disabled option before these two types. Hope this makes sense to you.

Thanks and have a nice day! Wyatt

Screen Shot 2021-07-13 at 1 40 21 pm
benwinding commented 3 years ago

Thanks @congweibai nice solution!

The only thing I would recommend is reducing formatting changes in future Pull Requests, as it makes it harder to review and see actual changes, but it otherwise looks great!

Will merge it in now 👍

congweibai commented 3 years ago

Thanks @benwinding, will take care of it in the future.