Problem when including via script tag - Githubissues

benwinding / quill-image-compress

A Quill rich text editor Module which compresses images uploaded to the editor

https://benwinding.github.io/quill-image-compress/src/demo.html

MIT License

123 stars 30 forks source link

Problem when including via script tag #2

Closed JohnArcher closed 5 years ago

JohnArcher commented 5 years ago

Hi there,

I want to use the lib the classic way (similar to https://github.com/kensnyder/quill-image-drop-module#script-tag) and include it via the script tag like so (I took the minified file from the dist folder):

<script src="quill.imageCompressor.min.js"></script>

Then I want to register the module:

Quill.register('modules/imageCompress', ImageCompress);

But this command leeds to this JavaScript error: Uncaught ReferenceError: ImageCompress is not defined

I assume the min file is not indented to be used this way!? If so would it be possible to provide a file that could be used like I would like to use it?

JaxonWright commented 5 years ago

This is how I got this way to work:

Use the non-minified version within the src directory.
Removed the last line of the js file (export default imageCompressor)
2nd parameter of the register needs to be imageCompressor.

benwinding commented 5 years ago

Hey guys, This should be fixed in 1.1.2, you can now use the library via a script tag Cheers

nickbe commented 3 years ago

Same problem with 1.2.14. The online demo uses the demo.js without including imageCompressor.js explicitly.

The error I get is:

Francesco96it commented 7 months ago

Same problem with latest version. Any solution?