search

benwtrent / janus-gateway-android

This is an API wrapper that utilizes the native WebRTC build and is made to ease communication with the janus-gateway
MIT License
112 stars 73 forks source link

Multiple code improvements - squid:S1192, squid:CommentedOutCodeLine, squid:S1213 #13

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrence of Sonar rules squid:S1192 - String literals should not be duplicated. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1213 Please let me know if you have any questions. George Kankava

benwtrent commented 8 years ago

:+1: I agree on removing the uncommented code, Examples of how to call things and set them up should be done in a wiki and not in code comments.