benwtrent / janus-gateway-android

This is an API wrapper that utilizes the native WebRTC build and is made to ease communication with the janus-gateway
MIT License
112 stars 73 forks source link

Multiple code improvements - squid:S2447, squid:S1149, squid:S3398 #14

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S2447 - Null should not be returned from a "Boolean" method. squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used. squid:S3398 - "private" methods called only by inner classes should be moved to those classes. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2447 https://dev.eclipse.org/sonar/rules/show/squid:S1149 Please let me know if you have any questions. George Kankava