search

benzado / NaSkeWriMo

The National Sketch Writing Month website
http://www.naskewrimo.org/
1 stars 1 forks source link

Issues #10 and #9 #24

Closed leom closed 13 years ago

leom commented 13 years ago

Hey -

Along with the changes to make the profile pic clickable and the data validation for the quotation marks, I added the general foundation for supporting mobile views. I'm on the fence about using the $isMobile var across the entire app vs. just creating a totally new mobile layout and switching on AppController::beforeFilter. Let me know what you think.

And also! The way I'm handling the validation error for the quotation marks is extremely kludgy, but unfortunately we lose cake's built in error handling display when we redirect from a controller, so that's a way around it. Oh, Cake.

thanks, and let me know if you've got questions. leo

benzado commented 13 years ago

Thanks for this! As far as I know, accepting a pull request is an all-or-nothing affair, so if you can avoid combining issues in the same commit/request, that would be helpful. I know that's not always easy, though, and I'd rather you submit something rather than nothing at all. Thanks again, it's nice to have help with this!