benzino77 / tasmocompiler

Web GUI for custom Tasmota compilation
MIT License
510 stars 148 forks source link

GUI - Proposal to add some new strings in language files #137

Closed bovirus closed 3 years ago

bovirus commented 3 years ago

@benzino77

If you can please modify the source code and language files to make these strings in the GUI multilanguage

"Generic ESP2866" "Sonoff Zigbee bridge" "Generic ESP32" "ESP32 webcam" "ESP32 odroid-go" "ESP32 M5Stack Core2"

"Generic ESP2866" - I propose to change this in English like "ESP8266 (Generic)" "Generic ESP32" - I propose to change this in English like "ESP32 (Generic)" The two changes propose is to have ESPxx as start of the string as the others.

If you can make the board selection in semi-alphabetical order (semi to check numerical order) and use scheme with use of "()". Like this

"ESP32 (generic)" "ESP32 (M5Stack Core2)" "ESP32 (odroid-go)" "ESP32 (webcam)" "ESP2866 (generic)" "Sonoff Zigbee (bridge)"

Thanks.

benzino77 commented 3 years ago

I don't like parenthesizes it doesn't look good. I like the idea to name it with the board type at the beginning and the model after that (in that order): "ESP8266 Generic" "Sonoff Zigbee Bridge" "ESP32 Generic" "ESP32 webcam" "ESP32 M5Stack Core2" "ESP32 Odroid-Go"

"ESP8266 Generic" has to be on the top of the list (first place) because it is the used most often.

There is no sense to translate those names (I think). There is lets say Toyota Highlander. You don't have translated name of that model in every particular country: Toyota Góral (in Poland)? Toyota Alpinista (in Italy)? Toyota Hegymászó (in Hungary)?

What I think, there can be tooltip for every board to describe more accurate every particular board (there is a tooltip now, but it can be more descriptive).

Anyway, make a pull request.

bovirus commented 3 years ago

@benzino77

I agree about own names that is no sense to transalte and infact I didn't propose to translate (only to use). But for "Generic" is no own name.

Then you could rename "ESP8266 Generic" in "ESP8266" without any other text and it's ok for all languages.

And have other ESP32 in alphabetical order

"ESP2866" "ESP32" "ESP32 M5Stack Core2" "ESP32 Odroid-Go" "ESP32 webcam"

Thanks.

benzino77 commented 3 years ago

I would rather leave "generic" word in place and give more descriptive tooltip. For example for "ESP8266 Generic" it can be: "This is probably board you should choose. It includes most SonOff and other popular devices" - and this tooltip is translated to other languages.

Make a PR - we will work on it.

bovirus commented 3 years ago

@benzino77

I suggested to avoid "Generic" because "Generic" is an English text and has a mix of translated GUI with some word in English for me is not the best view.

Probably if you add all board type as strings to add these strings to language file than anyone can customize as the each native language suggest.

For me remain valid laso to have EPS2866 then ESP32 in alphabetical order then Zigbee

Thanks. KR.

benzino77 commented 3 years ago

Closing as there is no activity. No PR made to review proposed changes.

drhideg commented 3 years ago

Sorry to post in a closed issue, but it's came up :)

Think Highlander as part/piece of the brand which mostly never translated. For me Generic is closer to general/universal. I would be happy to see if it can be translated.

By the way I think 8266 and 32 must be separated for clearance, since WeMos and NodeMCU has ESP32 based devices.

bovirus commented 3 years ago

@benzino77

My interest is to translate

Generic ESP8266 -> ESP8266 generica Generic ESP32 -> ESP32 generica

Because to have only two english strings in all rest of GUI that it's translated seems an error.

My scope is not translated other board names but only

"Generic xxxx"

string (and of course syntax because in italian "Generic xxx" if after board number name ("xxx generica").

Please leave this issue open as reminder...

benzino77 commented 3 years ago

Why the issue was closed:

Closing as there is no activity. No PR made to review proposed changes.

You haven't made any PR on which we can work on.

@drhideg You are right that current Wemos/NodeMCU should be rather ESP8266 Wemos/NodeMCU - I will change it. Maybe there should be some "separation" between esp8266 and esp32 as you suggested. I can't imagine how to implement it but ... all suggestions are welcome.

bovirus commented 3 years ago

@benzino77

I made only the the proposal because I don't have enough knowledge to propsoe a PR directly.

I think that you or @drhideg will have the knowledge to make the PR using my proposal.

drhideg commented 3 years ago

Values added by manually, but we can achieve something like this:

      <FormControl>
        <FormLabel>ESP 8266</FormLabel>
        <RadioGroup aria-label="board" name="board" value={board.name} onChange={this.handleRadioChange} row>
          <FormControlLabel value="esp8266" control={<Radio />} label="Generic" />
          <FormControlLabel value="esp82664M" control={<Radio />} label="Wemos/NodeMCU" />
          <FormControlLabel value="zbbridge" control={<Radio />} label="SonOff Zigbee Bridge" />
        </RadioGroup>
        <Divider />
        <FormLabel><br />ESP 32</FormLabel>
        <RadioGroup aria-label="board" name="board" value={board.name} onChange={this.handleRadioChange} row>
          <FormControlLabel value="esp32" control={<Radio />} label="Generic" />
          <FormControlLabel value="esp32webcam" control={<Radio />} label="Webcam" />
          <FormControlLabel value="esp32odroid" control={<Radio />} label="Odroid-Go" />
          <FormControlLabel value="esp32m5" control={<Radio />} label="M5Stack Core2" />
          <FormControlLabel value="esp32solo1" control={<Radio />} label="Solo1" />
        </RadioGroup>
      </FormControl>

Névtelen

bovirus commented 3 years ago

@drhideg

Wow!!! Many thanks. I foudn this solution very professional. Is it possible to modify the source to point the text string "Generic" in language files? Or you solution is ready for this?

If you save space in GUI you can try to show a solution like

EPS8266 - Generic / WeMos / NodeMCU / Sonoff Zigbee Bridge ESP 32 Generic / Webcam/ Odroid Go / M5Stach / Core2 Solo1

drhideg commented 3 years ago

@bovirus It's just a quick and dirty proof of concept, to see how it looks. If @benzino77 say it's okay for him, then all must rewrite becuse with this, need to maintain boards more than one place, which is not professional :)

benzino77 commented 3 years ago

Awesome! Just add more space/margin between boards and features: 117452986-b25cdf80-af44-11eb-9097-f86402074949

bovirus commented 3 years ago

@benzino77

Thanks a lot for GUI imporvemnts.

Please take care if you can enable the transaltion of

ESP8266 generic ESP32 generic