search

bepaald / signalbackup-tools

Tool to work with Signal Backup files.
GNU General Public License v3.0
790 stars 38 forks source link

If threadname includes "Umlaute" (äöüß) exporting to html with "--split [N]" there is an issue with generating link to sub pages #170

Closed hugogithubs closed 9 months ago

hugogithubs commented 9 months ago

Good evening,

Version: signalbackup-tools (signalbackup-tools) source version 20231229.154347 (Win)

There is a problem in links in html export if thread names have "Umlaute" (äöüß)

For example: A thread with Name "Jörg Familiyname" Mainpage of a thread (this works):

Link in browser: "file:///C:/signalbackup/test/signal-threads/J__rg%20FamilyName%20(_id35)/J__rg%20FamilyName.html"

Filename in file system: "J__rg FamilyName.html"

html source: ""

Failure if navigating to next page / page 1: Link in browser: "file:///C:/signalbackup/test/signal-threads/Jrg%20FamilyName%20(_id35)/J%c3%b6rg%20FamilyName_1.html" Filename in file system: "Jrg FamilyName_1.html"

html source: ""

hugogithubs commented 9 months ago

Oh, html code was automatically removed from post...

bepaald commented 9 months ago

Thanks for reporting! I'm not at home at the moment, and have a busy day today so I probably won't have time. I think I see the problem though, hopefully I'll have this fixed tomorrow. I'll update here once I do. Thanks again!

bepaald commented 9 months ago

I gave this a go very quickly. Let me know if it works now. I won't have time today anymore, if it's still giving problems I'll look at it again tomorrow. Thanks!

hugogithubs commented 9 months ago

Hi, thank you for this quick release. I just tested your latest release regarding this issue and it works fine now!

Thank you very much and I wish you a happy new year

bepaald commented 9 months ago

Thanks for reporting back, glad it's working! Happy new year to you as well!