search

bepaald / signalbackup-tools

Tool to work with Signal Backup files.
GNU General Public License v3.0
755 stars 36 forks source link

Database V215+ (currently in beta) breaks program #179

Closed bepaald closed 7 months ago

bepaald commented 8 months ago

At dbv215 (Signal 6.44, currently beta)

  1. the part table is renamed to attachment, and several of its columns are renamed.
  2. The unique_id column is completely removed from the table

I've dealt with renames such as (1) before. It's annoying and takes some time to fix, especially with such a heavily used table, but not a big problem.

As for (2), I've come up with a hacky way to deal with this (and retain backward compatibility), but I suspect many problems to arise. It will at least require thorough testing.

Just creating this issue since I expect the fixes to not be ready when this update reaches people (or for people running the beta).

Outlet2048 commented 7 months ago

Thanks for your work Very happy to see that the issue is already being worked on :D

bepaald commented 7 months ago

Thanks, I try :-)

Funny story though: the play store has not yet offered me the new beta on any of my testing phones, so I'm working completely blind. I just pushed a first pass, I'm sure it has bugs, since I can't test on any real backup file, but it's a start and at least shouldn't break anything on pre-215 databases.

If you (or anyone reading this) already has a new backup, feel free to test as much as you want and report the results. But don't feel obligated: I expect not much more work will be done until I actually get a new backup to work with.

Thanks!

Outlet2048 commented 7 months ago

Funny story though: the play store has not yet offered me the new beta on any of my testing phones, so I'm working completely blind.

Have you tried using firebase? Their betas appear there after 15-30 minutes after release And they also stopped pushing their .0 to Google play Only .1 and upwards will be available to Google play beta testers

bepaald commented 7 months ago

Have you tried using firebase? Their betas appear there after 15-30 minutes after release

Unfortunately the firebase testing group has no vacant spots, so I haven't been able to apply for a while now.

And they also stopped pushing their .0 to Google play Only .1 and upwards will be available to Google play beta testers

Ah, that explains the delay. I never had any problem with waiting a day or two for Google Play, but skipping the entire .0 release makes the delay a lot longer. But, it is what it is, nothing to do but wait for now... Thanks for the info

Outlet2048 commented 7 months ago

Unfortunately the firebase testing group has no vacant spots, so I haven't been able to apply for a while now.

ill ping one of the devs on the forum to see if some spots can be freed up It's the weekend so might take a while

bepaald commented 7 months ago

Thanks, though I'd feel bad if I bumped someone else of the list (or cut ahead on the waiting list). Anyway, it's moot now since .1 is out and available in the Play Store.

Now, I'll go see what the damage is...

bepaald commented 7 months ago

So, as far as I can tell I've gotten away with it pretty well. Forgot two small things, that I've fixed earlier today. Other than that, what I've tested seems to work. I'll sleep on it tonight, maybe I'll think of some more tests, but if not, I will probably just close this issue and wait for bug reports to come in.