bepaald / signalbackup-tools

Tool to work with Signal Backup files.
GNU General Public License v3.0
790 stars 38 forks source link

Remove mention of 404 issue 203 #241

Closed Benjamin-Loison closed 3 weeks ago

Benjamin-Loison commented 3 weeks ago
diff --git a/README.md b/README.md
index 3a07084..5928cb0 100644
--- a/README.md
+++ b/README.md
@@ -803,7 +803,7 @@ Running with these options does not require an input file to be provided. These
 - `--dumpdesktopdb [OUTPUTFILE]` Save the Desktop database to `[OUTPUTFILE]` without encryption.
 - `--rundtsqlquery [QUERY]` Run a query on the Desktop SQL database. Note that the database only resides in memory and any changes are _not_ saved to disk.
 - `--rundtprettysqlquery [QUERY]` As above, but tries to make the output a bit nicer to look at. Depending on the size of the query and the size of the output terminal, may make the output more ledgible (or less so).
-- `--exportdesktophtml [OUTPUTDIR]` Export the Signal Desktop database to HTML. This function works internally by creating an empty Android backup, importing the desktop into this and then exporting that internal Android backup to HTML. As a result it supports almost all modifying options mentioned in [import from Desktop](#desktop) and [export to HTML](#export-to-html) (excluding `--limittothreads`, and `--includesettings`). It also has the same limitations as both of these functions combined. It is currently unknown if, and how well it works. Feedback is appreciated. See: https://github.com/bepaald/signalbackup-tools/issues/203.
+- `--exportdesktophtml [OUTPUTDIR]` Export the Signal Desktop database to HTML. This function works internally by creating an empty Android backup, importing the desktop into this and then exporting that internal Android backup to HTML. As a result it supports almost all modifying options mentioned in [import from Desktop](#desktop) and [export to HTML](#export-to-html) (excluding `--limittothreads`, and `--includesettings`). It also has the same limitations as both of these functions combined. It is currently unknown if, and how well it works. Feedback is appreciated.
 - `--exportdesktoptxt [OUTPUTDIR]` Export the Signal Desktop database to plain text. Works as the above function, except the internal Android backup is [exported to TXT](#export-to-txt) instead.
 - `--desktopkey [HEXSTRING]` This is a modifying option for all desktop functions. Manually set the cipher key to use for decrypting the Signal Desktop database (see above note).
 - `--showdesktopkey` Shows the key used to decrypt the Signal Desktop database.

https://github.com/bepaald/signalbackup-tools/issues/203

Verified exhaustiveness thanks to:

grep -rw 203

https://github.com/bepaald/signalbackup-tools/issues/231 is the only issue/pull request mentioning this issue.

Initially published as #240.

bepaald commented 3 weeks ago

Thanks, that's a good find. I'm completely confused why that issue has disappeared though. It definitely used to exist, I still have e-mails about it and the wayback machine even has it in a snapshot: https://web.archive.org/web/20240526185515/https://github.com/bepaald/signalbackup-tools/issues

Screenshot 2024-09-25 at 17-18-06 Issues · bepaald_signalbackup-tools · GitHub

And as far as I know, only I (as the owner) can actually delete issues, but I only learned that googling right now, so it wasn't me.

Either way, it's a dead link now, so I will indeed remove it, and also a bit more, since the feature has been tested at least a few times now and I've had some positive feedback.

Thanks!