Some groups crash on signal-android after restoring message history with --importfromdesktop

[missytake]

• signal-android version: 7.26.1
• signal-desktop version: 7.34.0
• signalbackup-tools version: the windows executable which was the latest one on November 22

Thanks a lot for your effort on fixing the mess that is Signal's architecture! <3

What we did:

• in November, I accidentally wiped the phone of my partner while trying to de-google it. Then we realized we didn't have a backup of their signal-android message history. We still had a running signal-desktop client though.
• we re-register signal-android, thereby decoupling the signal-desktop client.
• we used the new signal-android app to export a more or less empty backup.
• we used signalbackup-tools to extract the database from the signal-desktop client and merge it with the new signal-android backup. I was following the discussion in https://github.com/bepaald/signalbackup-tools/issues/250#issuecomment-2484149113 meanwhile, it was shortly after you fixed a crash by inventing contact ids or something ;)
• we also deleted many older videos and audio files.
• we tried importing it into signal-android, but it claimed the passphrase was wrong. We changed it with --opassphrase.
• we imported the backup to signal-android, thereby re-registering it. With the new passphrase it worked.

What we tried then and what bugs we encountered:

• our 1:1 chat worked.
• then we tried messaging an existing group with 2 other friends - it had no messages, except a disappearance timer and some "X added Y". Opening the chat in signal-android made the app crash though.
• we re-coupled signal-desktop (but kept the old database around).
• we opened the crashing chat on signal-desktop - that works. it has even less message history of course.
• we opened a new chat with the same 2 friends, it doesn't crash on signal-android, even though it has the same members.
• many other groups also crash on signal-android, but not all.

We also have a signal-android log file and traceback, send me an email to missytake@systemli.org, then I can mail it to you :)

Priorities

My partner has a strong priority on having the message history on the phone, because it contains information important for daily life. Being reachable over signal follows directly after that. We are still hoping that we can save the message history though^^ And we also hope that once they get a phone with enough storage space we are able to restore all of the message history, including the old attachments.

[bepaald]

Hi!

There was an issue where the tool would import disappearing-timer-messages in groups incorrectly, causing crashes when opening these group chats (assuming you used the --importdesktopcontacts-option). This has been fixed in the meantime, but you probably performed the import before that fix. I strongly suspect you are running into this problem. To check, you could look at your crash log and check if it crashes with a message like: android.database.sqlite.SQLiteException: unknown error (code 0 SQLITE_OK): Unable to convert BLOB to string.

If you were to redo the process with the current version of the tool, this problem would probably not happen. Alternatively, it may be simpler to take the crashing Android backup (or export a new one) and run: signalbackup-tools [backup] [passphrase] --runsqlquery "DELETE FROM message WHERE TYPEOF(body) IS 'blob'" -o [output], which should delete the faulty messages and prevent any more crashes.

If you are seeing a different crash, or this doesn't fix it, please send me the crash log and I'll take a look if I can do anything. My email address is in the README (search for 'mail').

Let me know how it goes. Thanks!